review

Author: millotp

DOCKER_README.MD

@@ -28,7 +28,7 @@ docker run -it --rm --env ALGOLIA_APPLICATION_ID_1 \
                     --env ALGOLIA_ADMIN_KEY_1 \
                     --env ALGOLIA_SEARCH_KEY_1 \
                     --env ALGOLIA_APPLICATION_ID_2 \
-                    --env ALGOLIA_ADMIN_KEY_2
+                    --env ALGOLIA_ADMIN_KEY_2 \
                     --env ALGOLIA_APPLICATION_ID_MCM \
                     --env ALGOLIA_ADMIN_KEY_MCM \
 -v $PWD:/app -v /app/node_modules -w /app algolia-js bash

Dockerfile

@@ -6,7 +6,7 @@ FROM $NODE_IMAGE
 # Install the dependencies in the parent folder so they don't get overriden by the bind mount
 WORKDIR /
 
-# Needed to compile some npm packages
+# We need to install some dependencies for bundlesize (https://github.com/siddharthkp/bundlesize/pull/370)
 RUN apk add --no-cache bash python3 make g++
 
 COPY package.json yarn.lock ./