chore(release): small tweaks #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Haroenv
commented
Apr 21, 2020
Haroenv
commented
- add contributing guide (based on IS.js one)
- fix small error in api-extractor.json
- better link in CI comment in release script
- replace default with defaultValue: https://api-extractor.com/pages/tsdoc/tag_defaultvalue/
- put todo in separate comments so they aren't found by api-extractor
- avoid using > & {} in tsdoc comments, they can be confused with html apparently, and this looks nicer than the backslashes
- add contributing guide (based on IS.js one) - fix small error in api-extractor.json - better link in CI comment in release script - replace default with defaultValue: https://api-extractor.com/pages/tsdoc/tag_defaultvalue/ - put todo in separate comments so they aren't found by api-extractor - avoid using > & {} in tsdoc comments, they can be confused with html apparently
nunomaduro
reviewed
Apr 21, 2020
|
Thanks for this @Haroenv ! Can you check why lint tests are failing? |
nunomaduro
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.