chore(tests): tests against node 14 #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Jun 9, 2020
|
While adding "stable" would warn us if we are not compatible with the latest Node.js version it would also test against a moving target, making the tests more likely to fail without any apparent reason. Would be nice if we could test against "stable" but also allow tests failure on it. |
yannickcr
approved these changes
Jun 9, 2020
|
@yannickcr @Haroenv Can you perform a different pull request on that? Not sure I got it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node version 14 is available since the 21/04/2020: medium.com/@nodejs/node-js-version-14-available-now-8170d384567e
This pull request tests this library against that version.