Skip to content

fix(log-type-inner-queries): apply snake_case #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2020
Merged

fix(log-type-inner-queries): apply snake_case #1166

merged 2 commits into from
Jun 9, 2020

Conversation

nunomaduro
Copy link

@nunomaduro nunomaduro commented Jun 9, 2020 •
edited
Loading

Hey @Ant-hem , can you confirm that the type is now correct? Including what is optional or not:

  inner_queries: Array<{
    index_name: string; // required
    query_id?: string; // optional
    offset?: number; // optional
    user_token?: string; // optional
  }>;

@nunomaduro nunomaduro requested review from aseure and Ant-hem June 9, 2020 13:01
@nunomaduro nunomaduro self-assigned this Jun 9, 2020
Ant-hem
Ant-hem reviewed Jun 9, 2020
View reviewed changes
packages/client-search/src/types/Log.ts
@@ -91,6 +91,6 @@ export type Log = {
/**
* The user token of the query.
*/
readonly userToken: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userToken is optional

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean user_token right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, can you validate the pull request please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, user_token sorry.

Ant-hem
Ant-hem approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@Ant-hem Ant-hem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks.

@nunomaduro nunomaduro merged commit 648b06f into master Jun 9, 2020
@nunomaduro nunomaduro deleted the fix/log-type-inner-queries branch June 9, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ant-hem Ant-hem Ant-hem approved these changes

@aseure aseure Awaiting requested review from aseure

Assignees

@nunomaduro nunomaduro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nunomaduro @Ant-hem