fix(scripts): 2 years sla skips (#3490)

Author: shortcuts

config/release.config.json

@@ -24,6 +24,12 @@
   },
   "sla": {
     "csharp": {
+      "6.12.1": {
+        "releaseDate": "2022-02-14",
+        "supportStart": "2022-08-31",
+        "supportEnd": "2024-08-31",
+        "supportStatus": "maintenance"
+      },
       "6.13.0": {
         "releaseDate": "2022-08-31",
         "supportStart": "2022-11-08",
@@ -313,7 +319,6 @@
       },
       "3.31.2": {
         "releaseDate": "2024-06-25",
-        "supportEnd": "2024-06-25",
         "supportStatus": "active"
       }
     },
@@ -540,6 +545,12 @@
       }
     },
     "ruby": {
+      "2.2.5": {
+        "releaseDate": "2022-05-24",
+        "supportStart": "2022-09-26",
+        "supportEnd": "2024-09-26",
+        "supportStatus": "maintenance"
+      },
       "2.3.0": {
         "releaseDate": "2022-09-26",
         "supportEnd": "2022-10-21",

scripts/cli/index.ts

@@ -10,6 +10,7 @@ import { formatter } from '../formatter.js';
 import { generate } from '../generate.js';
 import { playground } from '../playground.js';
 import { createReleasePR } from '../release/createReleasePR.js';
+import { generateSLA } from '../release/sla.js';
 import { snippetsGenerateMany } from '../snippets/generate.js';
 import { buildSpecs } from '../specs';
 import type { Language } from '../types.js';
@@ -244,9 +245,16 @@ program
     undefined,
   )
   .option('-d, --dry-run', 'does not push anything to GitHub')
-  .action(async (langArgs: LangArg[], { verbose, releaseType, dryRun }) => {
+  .option('-sla, --sla-only', 'only generates the sla policy', false)
+  .action(async (langArgs: LangArg[], { verbose, releaseType, dryRun, slaOnly }) => {
     setVerbose(Boolean(verbose));
 
+    if (slaOnly) {
+      await generateSLA({});
+
+      return;
+    }
+
     if (langArgs.length === 0) {
       langArgs = [ALL];
     }

scripts/release/__tests__/sla.test.ts

@@ -71,11 +71,18 @@ describe('generateLanguageSLA', () => {
 
     it('ignores versions older than 2 years', () => {
       generateLanguageSLA([
+        "v1.0.9 Thu Dec 28 15:48:25 2011 +0000",
         "v1.1.4 Thu Dec 28 15:48:25 2021 +0000",
         "v1.4.7 Tue Jan 2 14:17:11 2024 +0000",
       ], 'php', {current: "1.4.7", next: null, releaseType: null})
 
       expect(fullReleaseConfig.sla.php).toEqual({
+        "1.1.4": {
+          "releaseDate": "2021-12-28",
+          "supportEnd": "2026-01-02",
+          "supportStart": "2024-01-02",
+          "supportStatus": "maintenance",
+        },
         "1.4.7": {
           "releaseDate": "2024-01-02",
           "supportStatus": "active",

scripts/release/sla.ts

@@ -14,7 +14,9 @@ function getMajorMinor(lang: Language, version: string): { major: number; minor:
   const matches = version.match(/(\d+)\.(\d+)/);
 
   if (!matches || matches.length < 3) {
-    throw new Error(`unable to parse version '${version}' for language '${lang}'`);
+    console.warn(`unable to parse version '${version}' for language '${lang}'`);
+
+    return { major: 0, minor: 0 };
   }
 
   return { major: parseInt(matches[1], 10), minor: parseInt(matches[2], 10) };
@@ -83,12 +85,15 @@ async function getTags(lang: Language): Promise<string[]> {
  */
 export function generateLanguageSLA(tags: string[], lang: Language, version: Version): void {
   const start = new Date();
+  const old = new Date(start);
+  old.setFullYear(start.getFullYear() - 2);
   const end = new Date(start);
   end.setFullYear(start.getFullYear() + 2);
 
   // @ts-expect-error -- force reset our sla policy to remove outdated ones
   fullReleaseConfig.sla[lang] = {};
 
+  let prevTagRelease = start;
   let prevTagMajor = 0;
   let prevTagMinor = 0;
   let prevTagVersion = '';
@@ -107,30 +112,39 @@ export function generateLanguageSLA(tags: string[], lang: Language, version: Ver
       continue;
     }
 
-    const releaseDate = new Date(tagReleaseDate);
-    const deadline = new Date(releaseDate);
-    deadline.setFullYear(releaseDate.getFullYear() + 2);
+    const { major: tagMajor, minor: tagMinor } = getMajorMinor(lang, tagVersion);
 
-    if (start.getTime() > deadline.getTime()) {
+    if (tagMajor === 0 && tagMinor === 0) {
       continue;
     }
 
-    const { major: tagMajor, minor: tagMinor } = getMajorMinor(lang, tagVersion);
-
-    fullReleaseConfig.sla[lang][tagVersion] = {
-      releaseDate: releaseDate.toISOString().split('T')[0],
-    };
+    const releaseDate = new Date(tagReleaseDate);
+    const deadline = new Date(releaseDate);
+    deadline.setFullYear(releaseDate.getFullYear() + 2);
 
     // the current tag version defines the maintenance policy of the previous one
     if (prevTagVersion !== '') {
       // if the previous tag is on the same major.minor version, we don't support it
       if (tagMajor === prevTagMajor && tagMinor === prevTagMinor) {
         setInactive(lang, prevTagVersion, releaseDate);
+
+        if (prevTagRelease.getTime() < old.getTime()) {
+          delete fullReleaseConfig.sla[lang][prevTagVersion];
+        }
       } else {
         setMaintenance(lang, prevTagVersion, releaseDate, deadline);
+
+        if (start.getTime() > deadline.getTime()) {
+          delete fullReleaseConfig.sla[lang][prevTagVersion];
+        }
       }
     }
 
+    fullReleaseConfig.sla[lang][tagVersion] = {
+      releaseDate: releaseDate.toISOString().split('T')[0],
+    };
+
+    prevTagRelease = releaseDate;
     prevTagMajor = tagMajor;
     prevTagMinor = tagMinor;
     prevTagVersion = tagVersion;