fix(scripts): release independently each language (#1374)

Author: millotp

clients/algoliasearch-client-java-2/.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
         uses: actions/setup-java@v3
         with:
           distribution: zulu
-          java-version-file: config/.java-version
+          java-version-file: .java-version
           cache: gradle
 
       - name: Validate gradle wrapper

clients/algoliasearch-client-java-2/.java-version

@@ -0,0 +1 @@
+11.0.18

clients/algoliasearch-client-javascript/.gitignore

@@ -1,5 +1,8 @@
 **dist
-**.openapi-generator
+**.openapi-generator*
+
+.DS_Store
+.env
 
 yarn-error.log
 
@@ -8,5 +11,3 @@ yarn-error.log
 !.yarn/plugins
 
 node_modules
-
-node_

scripts/ci/codegen/__tests__/spreadGeneration.test.ts

@@ -1,42 +1,7 @@
-import { LANGUAGES } from '../../../common';
-import { decideWhereToSpread, cleanUpCommitMessage } from '../spreadGeneration';
+import { cleanUpCommitMessage } from '../spreadGeneration';
 import text from '../text';
 
 describe('spread generation', () => {
-  describe('decideWhereToSpread', () => {
-    it('spreads to all languages if it is a release commit', () => {
-      expect(
-        decideWhereToSpread(`${text.commitReleaseMessage} [skip ci]`)
-      ).toEqual(LANGUAGES);
-    });
-
-    it('spreads to all languages if scope is missing', () => {
-      expect(decideWhereToSpread('chore: do something')).toEqual(LANGUAGES);
-    });
-
-    it('spreads to javascript if the scope is javascript', () => {
-      expect(decideWhereToSpread('fix(javascript): fix something')).toEqual([
-        'javascript',
-      ]);
-    });
-
-    LANGUAGES.forEach((lang) => {
-      it(`spreads to ${lang} if the scope is ${lang}`, () => {
-        expect(decideWhereToSpread(`fix(${lang}): fix something`)).toEqual([
-          lang,
-        ]);
-      });
-    });
-
-    it('spreads to all if scope is not specific language', () => {
-      ['cts', 'spec', 'script', 'ci'].forEach((scope) => {
-        expect(decideWhereToSpread(`fix(${scope}): fix something`)).toEqual(
-          LANGUAGES
-        );
-      });
-    });
-  });
-
   describe('cleanUpCommitMessage', () => {
     it('returns a release commit message with the version', () => {
       expect(

scripts/ci/codegen/spreadGeneration.ts

@@ -10,29 +10,14 @@ import {
   REPO_URL,
   ensureGitHubToken,
   configureGitHubAuthor,
+  setVerbose,
 } from '../../common';
 import { getLanguageFolder, getPackageVersionDefault } from '../../config';
 import { RELEASED_TAG } from '../../release/common';
-import type { Language } from '../../types';
 import { cloneRepository, getNbGitDiff } from '../utils';
 
 import text, { commitStartRelease } from './text';
 
-export function decideWhereToSpread(commitMessage: string): Language[] {
-  if (commitMessage.startsWith(commitStartRelease)) {
-    return LANGUAGES;
-  }
-
-  const result = commitMessage.match(/(.+)\((.+)\):/);
-  if (!result) {
-    // no scope
-    return LANGUAGES;
-  }
-
-  const scope = result[2] as Language;
-  return LANGUAGES.includes(scope) ? [scope] : LANGUAGES;
-}
-
 export function cleanUpCommitMessage(
   commitMessage: string,
   version: string
@@ -84,10 +69,9 @@ async function spreadGeneration(): Promise<void> {
     .filter(Boolean);
 
   const IS_RELEASE_COMMIT = lastCommitMessage.startsWith(commitStartRelease);
-  const langs = decideWhereToSpread(lastCommitMessage);
   console.log(
     'Spreading code to the following repositories:',
-    langs.join(' | ')
+    LANGUAGES.join(' | ')
   );
 
   // At this point, we know the release will happen on at least one client
@@ -99,70 +83,74 @@ async function spreadGeneration(): Promise<void> {
     await run(
       `git fetch origin refs/tags/${RELEASED_TAG}:refs/tags/${RELEASED_TAG}`
     );
-    await run(`git tag -d ${RELEASED_TAG}`);
     await run(`git push --delete origin ${RELEASED_TAG}`);
 
     console.log('Creating new `released` tag for latest commit');
     await run(`git tag ${RELEASED_TAG}`);
     await run('git push --tags');
   }
 
-  for (const lang of langs) {
-    const { tempGitDir } = await cloneRepository({
-      lang,
-      githubToken,
-      tempDir: process.env.RUNNER_TEMP!,
-    });
-
-    const clientPath = toAbsolutePath(getLanguageFolder(lang));
-    await emptyDirExceptForDotGit(tempGitDir);
-    await copy(clientPath, tempGitDir, { preserveTimestamps: true });
-
-    if (
-      (await getNbGitDiff({
-        head: null,
+  for (const lang of LANGUAGES) {
+    try {
+      const { tempGitDir } = await cloneRepository({
+        lang,
+        githubToken,
+        tempDir: process.env.RUNNER_TEMP!,
+      });
+
+      const clientPath = toAbsolutePath(getLanguageFolder(lang));
+      await emptyDirExceptForDotGit(tempGitDir);
+      await copy(clientPath, tempGitDir, { preserveTimestamps: true });
+
+      if (
+        (await getNbGitDiff({
+          head: null,
+          cwd: tempGitDir,
+        })) === 0
+      ) {
+        console.log(
+          `❎ Skipping ${lang} repository, because there is no change.`
+        );
+        continue;
+      } else {
+        console.log(`✅ Spreading code to the ${lang} repository.`);
+      }
+
+      const version = getPackageVersionDefault(lang);
+      const commitMessage = cleanUpCommitMessage(lastCommitMessage, version);
+
+      await configureGitHubAuthor(tempGitDir);
+
+      await run('git add .', { cwd: tempGitDir });
+      await gitCommit({
+        message: commitMessage,
+        coAuthors: [author, ...coAuthors],
         cwd: tempGitDir,
-      })) === 0
-    ) {
-      console.log(
-        `❎ Skipping ${lang} repository, because there is no change.`
-      );
-      continue;
-    } else {
-      console.log(`✅ Spreading code to the ${lang} repository.`);
-    }
-
-    const version = getPackageVersionDefault(lang);
-    const commitMessage = cleanUpCommitMessage(lastCommitMessage, version);
+      });
+      await run('git push', { cwd: tempGitDir });
 
-    await configureGitHubAuthor(tempGitDir);
+      // In case of a release commit, we also want to update tags on the clients repositories
+      if (IS_RELEASE_COMMIT) {
+        console.log(
+          `Processing release commit, creating new release tag ('${version}') for '${lang}' repository.`
+        );
 
-    await run('git add .', { cwd: tempGitDir });
-    await gitCommit({
-      message: commitMessage,
-      coAuthors: [author, ...coAuthors],
-      cwd: tempGitDir,
-    });
-    await run('git push', { cwd: tempGitDir });
+        // we always want to delete the tag in case it exists
+        await run(`git tag -d ${version} || true`, { cwd: tempGitDir });
+        await run(`git tag ${version} HEAD`, { cwd: tempGitDir });
+        await run('git push --tags', { cwd: tempGitDir });
+      }
 
-    // In case of a release commit, we also want to update tags on the clients repositories
-    if (IS_RELEASE_COMMIT) {
       console.log(
-        `Processing release commit, creating new release tag ('${version}') for '${lang}' repository.`
+        `✅ Code generation successfully pushed to ${lang} repository.`
       );
-
-      // we always want to delete the tag in case it exists
-      await run(`git tag -d ${version} || true`, { cwd: tempGitDir });
-      await run(`git tag ${version} HEAD`, { cwd: tempGitDir });
-      await run('git push --tags', { cwd: tempGitDir });
+    } catch (e) {
+      console.error(`Release failed for language ${lang}: ${e}`);
     }
-
-    console.log(
-      `✅ Code generation successfully pushed to ${lang} repository.`
-    );
   }
 }
 
 if (require.main === module) {
+  setVerbose(false);
   spreadGeneration();
 }