split external and dependencies concerns, update bundlesize

Author: shortcuts

clients/algoliasearch-client-javascript/base.rollup.config.js

@@ -91,11 +91,12 @@ function getBaseConfigs(pkg) {
   const packageName = pkg.name.replace(NPM_ORG, '');
   const isUtils = UTILS[packageName] !== undefined;
   const commonConfig = {
-    external: pkg.dependencies ? Object.keys(pkg.dependencies) : [],
+    dependencies: pkg.dependencies ? Object.keys(pkg.dependencies) : [],
     package: packageName,
     name: pkg.name,
     output: packageName,
     plugins: [],
+    external: [],
   };
 
   if (isUtils) {
@@ -140,7 +141,7 @@ function getBaseConfigs(pkg) {
         name: litePackageName,
         output: 'lite',
         input: 'lite/builds/browser.ts',
-        external: [
+        dependencies: [
           `${NPM_ORG}client-common`,
           `${NPM_ORG}requester-browser-xhr`,
         ],
@@ -156,7 +157,10 @@ function getBaseConfigs(pkg) {
         name: litePackageName,
         output: 'lite',
         input: 'lite/builds/node.ts',
-        external: [`${NPM_ORG}client-common`, `${NPM_ORG}requester-node-http`],
+        dependencies: [
+          `${NPM_ORG}client-common`,
+          `${NPM_ORG}requester-node-http`,
+        ],
       }
     );
   }
@@ -229,7 +233,7 @@ export function buildConfigs(pkg) {
 
       if (isUmdBuild || isEsmBrowserBuild) {
         // eslint-disable-next-line no-param-reassign
-        baseConfig.external = [];
+        baseConfig.dependencies = [];
       }
 
       if (isUmdBuild) {
@@ -263,7 +267,7 @@ export function buildConfigs(pkg) {
 
       rollupConfig.push({
         input: baseConfig.input,
-        external: baseConfig.external,
+        external: [...baseConfig.external, ...baseConfig.dependencies],
         plugins: [
           globals({
             global: true,

clients/algoliasearch-client-javascript/bundlesize.config.json

@@ -2,47 +2,47 @@
   "files": [
     {
       "path": "packages/algoliasearch/dist/algoliasearch.umd.js",
-      "maxSize": "8.60KB"
+      "maxSize": "7.75KB"
     },
     {
       "path": "packages/algoliasearch/dist/lite/lite.umd.js",
-      "maxSize": "3.85KB"
+      "maxSize": "3.50KB"
     },
     {
       "path": "packages/client-abtesting/dist/client-abtesting.umd.js",
-      "maxSize": "4.00KB"
+      "maxSize": "3.65KB"
     },
     {
       "path": "packages/client-analytics/dist/client-analytics.umd.js",
-      "maxSize": "4.60KB"
+      "maxSize": "4.30KB"
     },
     {
       "path": "packages/client-insights/dist/client-insights.umd.js",
-      "maxSize": "3.80KB"
+      "maxSize": "3.50KB"
     },
     {
       "path": "packages/client-personalization/dist/client-personalization.umd.js",
-      "maxSize": "3.95KB"
+      "maxSize": "3.60KB"
     },
     {
       "path": "packages/client-query-suggestions/dist/client-query-suggestions.umd.js",
-      "maxSize": "4.00KB"
+      "maxSize": "3.65KB"
     },
     {
       "path": "packages/client-search/dist/client-search.umd.js",
-      "maxSize": "6.90KB"
+      "maxSize": "6.35KB"
     },
     {
       "path": "packages/client-sources/dist/client-sources.umd.js",
-      "maxSize": "3.85KB"
+      "maxSize": "3.50KB"
     },
     {
       "path": "packages/predict/dist/predict.umd.js",
-      "maxSize": "3.85KB"
+      "maxSize": "3.50KB"
     },
     {
       "path": "packages/recommend/dist/recommend.umd.js",
-      "maxSize": "3.85KB"
+      "maxSize": "3.50KB"
     }
   ]
 }

playground/javascript/node/algoliasearch.ts

@@ -1,4 +1,4 @@
-import { algoliasearch } from 'algoliasearch';
+import { algoliasearch, SearchClient } from 'algoliasearch';
 import { liteClient } from 'algoliasearch/lite';
 import { ApiError } from '@algolia/client-common';
 import dotenv from 'dotenv';