Skip to content

Commit 3b85c76

Browse files
fix(javascript): use exports field to pick correct bundle (#947)
Co-authored-by: Clément Vannicatte <[email protected]>
1 parent 5dbadda commit 3b85c76

File tree

2 files changed

+39
-16
lines changed

2 files changed

+39
-16
lines changed

playground/javascript/node/search.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import { searchClient } from '@algolia/client-search';
2+
import { apiClientVersion } from '@algolia/client-search/src/searchClient';
3+
import { SearchQuery } from '@algolia/client-search/model';
24
import { ApiError } from '@algolia/client-common';
35
import dotenv from 'dotenv';
46

@@ -15,13 +17,18 @@ const client = searchClient(appId, apiKey);
1517

1618
client.addAlgoliaAgent('Node playground', '0.0.1');
1719

20+
const requests: SearchQuery[] = [
21+
{ indexName: searchIndex, query: searchQuery },
22+
];
23+
console.log('verison', apiClientVersion, 'requests', requests);
24+
1825
async function testSearch() {
1926
try {
2027
const res = await client.search<{ name: string }>({
21-
requests: [{ indexName: searchIndex, query: searchQuery }],
28+
requests,
2229
});
2330

24-
console.log(`[OK]`, res.results[0].hits![0].name);
31+
console.log(`[OK]`, res);
2532
} catch (e: any) {
2633
// Instance of
2734
if (e instanceof ApiError) {

templates/javascript/clients/package.mustache

Lines changed: 30 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,31 @@
33
"repository": "{{gitUserId}}/{{gitRepoId}}",
44
"license": "MIT",
55
"author": "Algolia",
6+
"types": "./index.d.ts",
67
{{^isAlgoliasearchClient}}
78
"name": "{{{npmNamespace}}}/{{packageName}}",
89
"description": "JavaScript client for {{packageName}}",
9-
"main": "index.js",
10-
"jsdelivr": "dist/{{packageName}}.umd.js",
11-
"unpkg": "dist/{{packageName}}.umd.js",
12-
"module": "dist/{{packageName}}.esm.node.js",
13-
"browser": "dist/{{packageName}}.umd.js",
10+
"jsdelivr": "./dist/{{packageName}}.umd.js",
11+
"unpkg": "./dist/{{packageName}}.umd.js",
12+
"browser": "./dist/{{packageName}}.umd.js",
13+
"exports": {
14+
".": {
15+
"node": {
16+
"import": "./dist/{{packageName}}.esm.node.js",
17+
"module": "./dist/{{packageName}}.esm.node.js",
18+
"require": "./dist/{{packageName}}.cjs.js",
19+
"default": "./dist/{{packageName}}.cjs.js"
20+
},
21+
"default": {
22+
"umd": "./dist/{{packageName}}.umd.js",
23+
"module": "./dist/{{packageName}}.esm.browser.js",
24+
"import": "./dist/{{packageName}}.esm.browser.js",
25+
"default": "./dist/{{packageName}}.umd.js"
26+
}
27+
},
28+
"./src/*": "./src/*.ts",
29+
"./model": "./model/index.ts"
30+
},
1431
"files": [
1532
"dist",
1633
"model",
@@ -35,6 +52,12 @@
3552
{{#isAlgoliasearchClient}}
3653
"name": "{{packageName}}",
3754
"description": "A fully-featured and blazing-fast JavaScript API client to interact with Algolia API.",
55+
"jsdelivr": "./dist/algoliasearch.umd.js",
56+
"unpkg": "./dist/algoliasearch.umd.js",
57+
"browser": {
58+
"./index.js": "./dist/algoliasearch.umd.js",
59+
"./lite.js": "./dist/lite/lite.umd.js"
60+
},
3861
"exports": {
3962
".": {
4063
"types": "./index.d.ts",
@@ -44,7 +67,7 @@
4467
"require": "./dist/algoliasearch.cjs.js",
4568
"default": "./dist/algoliasearch.cjs.js"
4669
},
47-
"browser": {
70+
"default": {
4871
"umd": "./dist/algoliasearch.umd.js",
4972
"module": "./dist/algoliasearch.esm.browser.js",
5073
"import": "./dist/algoliasearch.esm.browser.js",
@@ -59,20 +82,14 @@
5982
"require": "./dist/lite/lite.cjs.js",
6083
"default": "./dist/lite/lite.cjs.js"
6184
},
62-
"browser": {
85+
"default": {
6386
"umd": "./dist/lite/lite.umd.js",
6487
"module": "./dist/lite/lite.esm.browser.js",
6588
"import": "./dist/lite/lite.esm.browser.js",
6689
"default": "./dist/lite/lite.umd.js"
6790
}
6891
}
6992
},
70-
"jsdelivr": "./dist/algoliasearch.umd.js",
71-
"unpkg": "./dist/algoliasearch.umd.js",
72-
"browser": {
73-
"./index.js": "./dist/algoliasearch.umd.js",
74-
"./lite.js": "./dist/lite/lite.umd.js"
75-
},
7693
"files": [
7794
"dist",
7895
"builds",
@@ -105,7 +122,6 @@
105122
"rollup": "2.78.1"
106123
},
107124
{{/isAlgoliasearchClient}}
108-
"types": "index.d.ts",
109125
"engines": {
110126
"node": ">= 14.0.0"
111127
}

0 commit comments

Comments
 (0)