Skip to content

Commit 48cd2a1

Browse files
committed
fix(specs): fix missing params and types
1 parent d358fdf commit 48cd2a1

File tree

14 files changed

+974
-387
lines changed

14 files changed

+974
-387
lines changed

clients/algoliasearch-client-php/lib/Model/Search/SchemasQuery.php

Lines changed: 0 additions & 242 deletions
This file was deleted.

generators/src/main/java/com/algolia/codegen/cts/manager/JavaCTSManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public JavaCTSManager(String client) {
1515

1616
@Override
1717
public void addSupportingFiles(List<SupportingFile> supportingFiles) {
18-
supportingFiles.add(new SupportingFile("build.mustache", ".", "build.gradle"));
18+
supportingFiles.add(new SupportingFile("build.mustache", "", "build.gradle"));
1919
}
2020

2121
@Override

generators/src/main/java/com/algolia/codegen/cts/tests/ParametersWithDataType.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,13 @@ private void handleModel(
305305
}
306306
if (varSpec == null) {
307307
throw new CTSException(
308-
"Parameter " + entry.getKey() + " not found in " + paramName + ". You might have a type conflict in the spec for " + baseType
308+
"Parameter '" +
309+
entry.getKey() +
310+
"' not found in '" +
311+
paramName +
312+
"'. You might have a type conflict in the spec for '" +
313+
baseType +
314+
"'"
309315
);
310316
}
311317

specs/abtesting/common/parameters.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ endAt:
2222

2323
createdAt:
2424
type: string
25-
description: End date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
25+
description: Create date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
26+
27+
updatedAt:
28+
type: string
29+
description: Update date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
2630

2731
name:
2832
type: string

specs/abtesting/common/schemas/ABTest.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ ABTest:
2020
description: A/B test significance based on conversion data. Should be > 0.95 to be considered significant (no matter which variant is winning).
2121
endAt:
2222
$ref: '../parameters.yml#/endAt'
23+
updatedAt:
24+
$ref: '../parameters.yml#/updatedAt'
2325
createdAt:
2426
$ref: '../parameters.yml#/createdAt'
2527
name:
@@ -34,6 +36,7 @@ ABTest:
3436
- name
3537
- createdAt
3638
- endAt
39+
- updatedAt
3740
- conversionSignificance
3841
- clickSignificance
3942
- abTestID

0 commit comments

Comments
 (0)