Skip to content

Commit 4af574e

Browse files
committed
fix !GET method body
1 parent 5c912e7 commit 4af574e

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

generators/src/main/java/com/algolia/codegen/cts/tests/TestsRequest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,13 @@ public void run(Map<String, CodegenModel> models, Map<String, CodegenOperation>
6060
test.put("method", operationId);
6161
test.put("testName", req.testName == null ? operationId : req.testName);
6262
test.put("testIndex", i);
63+
64+
// We've defaulted the body to be an empty object for all methods
65+
// but `GET` methods does not have a body.
66+
if (req.request.method.equals("GET")) {
67+
req.request.body = null;
68+
}
69+
6370
test.put("request", req.request);
6471
test.put("hasParameters", req.parameters.size() != 0);
6572

templates/java/tests/requests/requests.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ class {{client}}RequestsTests {
6666

6767
assertEquals(req.path, "{{{request.path}}}");
6868
assertEquals(req.method, "{{{request.method}}}");
69-
7069
{{#request.body}}
7170
assertDoesNotThrow(() -> {
7271
JSONAssert.assertEquals("{{#lambda.escapeQuotes}}{{{request.body}}}{{/lambda.escapeQuotes}}", req.body, JSONCompareMode.STRICT);

templates/javascript/tests/requests/requests.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('{{operationId}}', () => {
2121

2222
expect(req.path).toEqual('{{{request.path}}}');
2323
expect(req.method).toEqual('{{{request.method}}}');
24-
expect(req.data).toEqual({{{request.body}}});
24+
expect(req.data).toEqual({{#request.body}}{{{.}}}{{/request.body}}{{^request.body}}undefined{{/request.body}});
2525
expect(req.searchParams).toStrictEqual({{#request.queryParameters}}{{{.}}}{{/request.queryParameters}}{{^request.queryParameters}}undefined{{/request.queryParameters}});
2626
{{#request.headers}}
2727
expect(req.headers).toEqual(

templates/php/tests/requests/requests.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class {{clientPrefix}}Test extends TestCase implements HttpClientInterface
115115
"path" => "{{{request.path}}}",
116116
"method" => "{{{request.method}}}",
117117
{{#request.body}}
118-
"body" => json_decode("{{#lambda.escapeQuotes}}{{{request.body}}}{{/lambda.escapeQuotes}}"),
118+
"body" => json_decode("{{#lambda.escapeQuotes}}{{{.}}}{{/lambda.escapeQuotes}}"),
119119
{{/request.body}}
120120
{{#request.queryParameters}}
121121
"queryParameters" => json_decode("{{#lambda.escapeQuotes}}{{{request.queryParameters}}}{{/lambda.escapeQuotes}}", true),

0 commit comments

Comments
 (0)