Skip to content

Commit 4d7811a

Browse files
committed
fix: do not default version
1 parent 13edf22 commit 4d7811a

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

clients/algoliasearch-client-python/algoliasearch/http/user_agent.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ def __init__(self) -> None:
1919
def get(self) -> str:
2020
return self.value
2121

22-
def add(self, segment: str, version: Optional[str] = __version__) -> Self:
23-
self.value += "; {} ({})".format(segment, __version__ if version is None else version)
22+
def add(self, segment: str, version: Optional[str] = None) -> Self:
23+
self.value += "; {}".format(segment)
24+
25+
if version is not None:
26+
self.value += " ({})".format(version)
27+
2428
return self

playground/python/app/search.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ def main():
1414
environ.get("ALGOLIA_APPLICATION_ID"), environ.get("ALGOLIA_ADMIN_KEY")
1515
)
1616
client.add_user_agent("playground")
17+
client.add_user_agent("bar", "baz")
1718

1819
print("user_agent", client._config._user_agent.get())
1920
print("client initialized", client)

templates/python/config.mustache

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ from algoliasearch.http.hosts import (
88
)
99
from algoliasearch.http.user_agent import UserAgent
1010
from algoliasearch.http.base_config import BaseConfig
11+
from algoliasearch import __version__
1112

1213

1314
class {{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}Config(BaseConfig):
1415
def __init__(self, app_id: Optional[str], api_key: Optional[str]{{#hasRegionalHost}}, region: {{#fallbackToAliasHost}}Optional[str] = None{{/fallbackToAliasHost}}{{^fallbackToAliasHost}}str = ""{{/fallbackToAliasHost}}{{/hasRegionalHost}}) -> None:
1516
super().__init__(app_id, api_key)
1617

17-
self._user_agent = UserAgent().add("{{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}")
18+
self._user_agent = UserAgent()
19+
self.add_user_agent("{{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}", __version__)
1820

1921
if app_id is None or not app_id:
2022
raise ValueError("`app_id` is missing.")

0 commit comments

Comments
 (0)