Skip to content

Commit 6ee8056

Browse files
committed
typo broke the build
1 parent a0cd2bb commit 6ee8056

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

.github/.cache_version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.0.5
1+
0.0.6

clients/algoliasearch-client-javascript/base.rollup.config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import fs from 'fs';
44
const NPM_ORG = '@experimental-api-clients-automation/';
55

66
// Output formats
7-
const BROWSER_FORMATS = ['esm-browser', 'umd-browser', 'cjs-browser'];
7+
const BROWSER_FORMATS = ['esm-browser', 'cjs-browser', 'umd-browser'];
88
const NODE_FORMATS = ['esm-node', 'cjs-node'];
99

1010
// Utils package with default options
@@ -125,7 +125,7 @@ export function getPackageConfigs() {
125125
external: ['dom'],
126126
dependencies: [
127127
...commonConfig.dependencies,
128-
`${NPM_ORG}/requester-browser-xhr`,
128+
`${NPM_ORG}requester-browser-xhr`,
129129
],
130130
globals: {
131131
[packageName]: packageName,
@@ -138,7 +138,7 @@ export function getPackageConfigs() {
138138
formats: NODE_FORMATS,
139139
dependencies: [
140140
...commonConfig.dependencies,
141-
`${NPM_ORG}/requester-node-http`,
141+
`${NPM_ORG}requester-node-http`,
142142
],
143143
},
144144
];

clients/algoliasearch-client-javascript/rollup.config.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const rollupConfig = [];
1818

1919
packageConfigs.forEach((packageConfig) => {
2020
let checkForTypes = true;
21-
2221
const clientPath = path.resolve('packages', packageConfig.package);
2322
const clientPackageJson = JSON.parse(
2423
fs.readFileSync(path.resolve(clientPath, 'package.json'))
@@ -36,15 +35,6 @@ packageConfigs.forEach((packageConfig) => {
3635
packageConfig.formats.forEach((format) => {
3736
const isUmdBuild = format === 'umd-browser';
3837
const isEsmBrowserBuild = format === 'esm-browser';
39-
40-
if (isUmdBuild) {
41-
bundlers[format].name = packageConfig.name;
42-
bundlers[format].banner = createLicense(
43-
packageConfig.package,
44-
clientPackageJson.version
45-
);
46-
}
47-
4838
const umdConfig = {
4939
compressorPlugins: [],
5040
transpilerPlugins: [],
@@ -56,6 +46,12 @@ packageConfigs.forEach((packageConfig) => {
5646
}
5747

5848
if (isUmdBuild) {
49+
bundlers[format].name = packageConfig.name;
50+
bundlers[format].banner = createLicense(
51+
packageConfig.package,
52+
clientPackageJson.version
53+
);
54+
5955
umdConfig.compressorPlugins = [terser()];
6056
umdConfig.transpilerPlugins = [
6157
babel({
@@ -93,6 +89,7 @@ packageConfigs.forEach((packageConfig) => {
9389
compilerOptions: {
9490
declaration: checkForTypes,
9591
declarationMap: checkForTypes,
92+
noEmit: !checkForTypes,
9693
},
9794
},
9895
}),

0 commit comments

Comments
 (0)