fix(ruby): make sure to return a status code from an http error

Author: Fluf22

clients/algoliasearch-client-ruby/lib/algolia/transport/transport.rb

@@ -68,7 +68,7 @@ def request(call_type, method, path, body, opts = {})
           )
           if outcome == FAILURE
             decoded_error = JSON.parse(response.error, :symbolize_names => true)
-            raise Algolia::AlgoliaHttpError.new(decoded_error[:status], decoded_error[:message])
+            raise Algolia::AlgoliaHttpError.new(response.status, decoded_error[:message])
           end
 
           return response unless outcome == RETRY

templates/ruby/search_helpers.mustache

@@ -53,19 +53,15 @@ def wait_for_api_key(key, operation, api_key = {}, max_retries = 50, timeout = -
   if operation == 'update'
     raise ArgumentError, '`api_key` is required when waiting for an `update` operation.' if api_key.nil?
     while retries < max_retries
-      begin
-        updatad_key = get_api_key(key, request_options)
-        updated_key_hash = updatad_key.to_hash
-        equals = true
-        api_key.to_hash.each do |k, v|
-          equals &&= updated_key_hash[k] == v
-        end
-      
-        return updatad_key if equals
-      rescue AlgoliaError => e
-        raise e unless e.code == 404
+      updated_key = get_api_key(key, request_options)
+      updated_key_hash = updated_key.to_hash
+      equals = true
+      api_key.to_hash.each do |k, v|
+        equals &&= updated_key_hash[k] == v
       end
 
+      return updated_key if equals
+
       retries += 1
       sleep(timeout.call(retries) / 1000.0)
     end
@@ -76,13 +72,19 @@ def wait_for_api_key(key, operation, api_key = {}, max_retries = 50, timeout = -
   while retries < max_retries
     begin
       res = get_api_key(key, request_options)
-      return res if operation == 'add'
-    rescue AlgoliaError => e
-      return res if operation == 'delete' && e.code == 404
+      return res if operation == "add"
+    rescue AlgoliaHttpError => e
+      if e.code == 404
+        return nil if operation == "delete"
+      else
+        raise e
+      end
     end
+
     retries += 1
     sleep(timeout.call(retries) / 1000.0)
   end
+
   raise ApiError, "The maximum number of retries exceeded. (#{max_retries})"
 end