Skip to content

Commit 9243601

Browse files
authored
chore: remove utils CI for JS (#3177)
1 parent 5b77d51 commit 9243601

File tree

5 files changed

+17
-64
lines changed

5 files changed

+17
-64
lines changed

.github/workflows/check.yml

Lines changed: 3 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -143,58 +143,11 @@ jobs:
143143
name: specs
144144
path: ${{ fromJSON(needs.setup.outputs.SPECS_MATRIX).bundledPath }}
145145

146-
client_javascript_utils:
147-
timeout-minutes: 10
148-
runs-on: ubuntu-22.04
149-
needs: setup
150-
if: ${{ needs.setup.outputs.RUN_GEN_JAVASCRIPT == 'true' }}
151-
strategy:
152-
matrix:
153-
client:
154-
- client-common
155-
- requester-browser-xhr
156-
- requester-node-http
157-
- requester-fetch
158-
steps:
159-
- uses: actions/checkout@v4
160-
161-
- name: Cache '${{ matrix.client }}' client folder
162-
if: ${{ github.ref != 'refs/heads/main' }}
163-
id: cache
164-
uses: actions/cache@v4
165-
with:
166-
key: |
167-
${{ matrix.client }}-${{ hashFiles(
168-
format('clients/algoliasearch-client-javascript/packages/{0}/**', matrix.client),
169-
'clients/algoliasearch-client-javascript/yarn.lock'
170-
)}}
171-
path: clients/algoliasearch-client-javascript/packages/${{ matrix.client }}
172-
173-
- name: Remove generated clients
174-
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
175-
run: cd clients/algoliasearch-client-javascript/packages && ls | grep -v -E "(client-common|requester-*)" | xargs rm -rf
176-
177-
- name: Setup
178-
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
179-
uses: ./.github/actions/setup
180-
with:
181-
type: minimal
182-
language: javascript
183-
184-
- name: Build '${{ matrix.client }}' client
185-
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
186-
run: cd clients/algoliasearch-client-javascript && yarn build:many @algolia/${{ matrix.client }}
187-
188-
- name: Run tests for '${{ matrix.client }}'
189-
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
190-
run: cd clients/algoliasearch-client-javascript && yarn workspace @algolia/${{ matrix.client }} test
191-
192146
client_gen_javascript:
193147
timeout-minutes: 10
194148
runs-on: ubuntu-22.04
195149
needs:
196150
- setup
197-
- client_javascript_utils
198151
- specs
199152
- scripts
200153
if: |
@@ -236,14 +189,13 @@ jobs:
236189
- name: Build clients
237190
run: ${{ fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).buildCommand }}
238191

192+
- name: Run common and requester tests
193+
run: cd clients/algoliasearch-client-javascript && yarn test
194+
239195
- name: Test JavaScript bundle size
240196
if: ${{ startsWith(env.head_ref, 'chore/prepare-release-') }}
241197
run: cd clients/algoliasearch-client-javascript && yarn test:size
242198

243-
- name: Run JavaScript 'algoliasearch' client tests
244-
if: ${{ contains(fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).toRun,'algoliasearch') }}
245-
run: cd clients/algoliasearch-client-javascript && yarn workspace algoliasearch test
246-
247199
- name: Remove previous CTS output
248200
run: rm -rf ${{ fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).testsToDelete }}
249201

clients/algoliasearch-client-javascript/bundlesize.config.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,47 +2,47 @@
22
"files": [
33
{
44
"path": "packages/algoliasearch/dist/algoliasearch.umd.js",
5-
"maxSize": "8.10KB"
5+
"maxSize": "8.65KB"
66
},
77
{
88
"path": "packages/algoliasearch/dist/lite/lite.umd.js",
9-
"maxSize": "3.70KB"
9+
"maxSize": "3.90KB"
1010
},
1111
{
1212
"path": "packages/client-abtesting/dist/client-abtesting.umd.js",
13-
"maxSize": "3.90KB"
13+
"maxSize": "4.05KB"
1414
},
1515
{
1616
"path": "packages/client-analytics/dist/client-analytics.umd.js",
17-
"maxSize": "4.50KB"
17+
"maxSize": "4.75KB"
1818
},
1919
{
2020
"path": "packages/client-insights/dist/client-insights.umd.js",
21-
"maxSize": "3.65KB"
21+
"maxSize": "3.90KB"
2222
},
2323
{
2424
"path": "packages/client-personalization/dist/client-personalization.umd.js",
25-
"maxSize": "3.80KB"
25+
"maxSize": "4.05KB"
2626
},
2727
{
2828
"path": "packages/client-query-suggestions/dist/client-query-suggestions.umd.js",
29-
"maxSize": "3.85KB"
29+
"maxSize": "4.05KB"
3030
},
3131
{
3232
"path": "packages/client-search/dist/client-search.umd.js",
33-
"maxSize": "6.60KB"
33+
"maxSize": "7.05KB"
3434
},
3535
{
3636
"path": "packages/ingestion/dist/ingestion.umd.js",
37-
"maxSize": "5.05KB"
37+
"maxSize": "5.20KB"
3838
},
3939
{
4040
"path": "packages/monitoring/dist/monitoring.umd.js",
41-
"maxSize": "3.90KB"
41+
"maxSize": "3.95KB"
4242
},
4343
{
4444
"path": "packages/recommend/dist/recommend.umd.js",
45-
"maxSize": "3.95KB"
45+
"maxSize": "4.10KB"
4646
}
4747
]
4848
}

clients/algoliasearch-client-javascript/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"clean": "lerna run clean --include-dependencies",
1212
"release:bump": "lerna version ${0:-patch} --no-changelog --no-git-tag-version --no-push --exact --force-publish --yes",
1313
"release:publish": "tsc --project tsconfig.script.json && node dist/scripts/publish.js",
14+
"test": "lerna run test",
1415
"test:size": "bundlesize"
1516
},
1617
"devDependencies": {

clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ describe('timeout handling', () => {
118118
beforeAll(() => {
119119
server = createTestServer();
120120

121-
server.listen('1111');
121+
server.listen('1113');
122122
});
123123

124124
afterAll((done) => {

clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ describe('timeout handling', () => {
174174
beforeAll(() => {
175175
server = createTestServer();
176176

177-
server.listen('1111');
177+
server.listen('1112');
178178
});
179179

180180
afterAll((done) => {

0 commit comments

Comments
 (0)