fix(clients): send empty object on empty request body

Author: shortcuts

clients/algoliasearch-client-java-2/algoliasearch-core/src/main/java/com/algolia/ApiClient.java

@@ -244,7 +244,8 @@ public RequestBody serialize(Object obj) throws AlgoliaRuntimeException {
         throw new AlgoliaRuntimeException(e);
       }
     } else {
-      content = null;
+      // An empty body is defaulted to "{}" to match an empty JSON object
+      content = "{}";
     }
 
     return RequestBody.create(content, MediaType.parse(this.contentType));
@@ -345,14 +346,6 @@ public Request buildRequest(
     RequestBody reqBody;
     if (!HttpMethod.permitsRequestBody(method)) {
       reqBody = null;
-    } else if (body == null) {
-      if ("DELETE".equals(method)) {
-        // allow calling DELETE without sending a request body
-        reqBody = null;
-      } else {
-        // use an empty request body (for POST, PUT and PATCH)
-        reqBody = RequestBody.create("", MediaType.parse(this.contentType));
-      }
     } else {
       reqBody = serialize(body);
     }

clients/algoliasearch-client-php/lib/RetryStrategy/ApiWrapper.php

@@ -277,10 +277,9 @@ private function createRequest(
         $protocolVersion = '1.1'
     ) {
         if (is_array($body)) {
-            // Send an empty body instead of "[]" in case there are
-            // no content/params to send
+            // An empty body is defaulted to "{}" to match an empty JSON object
             if (empty($body)) {
-                $body = '';
+                $body = '{}';
             } else {
                 $body = \json_encode($body, $this->jsonOptions);
                 if (JSON_ERROR_NONE !== json_last_error()) {

config/generation.config.js

@@ -27,7 +27,7 @@ module.exports = {
     '!clients/algoliasearch-client-javascript/packages/algoliasearch/jest.config.ts',
 
     // PHP
-    '!clients/algoliasearch-client-php/*',
+    '!clients/algoliasearch-client-php/**',
     'clients/algoliasearch-client-php/lib/Api/*',
     'clients/algoliasearch-client-php/lib/Model/**',
     'clients/algoliasearch-client-php/lib/Configuration/*',