Skip to content

Commit aa5abeb

Browse files
committed
remove unused code
1 parent db248d0 commit aa5abeb

File tree

3 files changed

+3
-57
lines changed

3 files changed

+3
-57
lines changed

.github/actions/restore-artifacts/action.yml

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ description: |
77
88
inputs:
99
type:
10-
description: Type of artifacts to restore (`all` | `specs` | `js_utils`)
10+
description: Type of artifacts to restore (`all` | `specs`)
1111
required: false
1212
php:
1313
description: Whether this job ran or not
@@ -30,35 +30,6 @@ runs:
3030
name: specs
3131
path: specs/bundled/
3232

33-
# JavaScript utils
34-
- name: client-javascript-utils-client-common
35-
if: ${{ (inputs.javascript == 'true' && inputs.type == 'all') || inputs.type == 'js_utils' }}
36-
uses: actions/download-artifact@v3
37-
with:
38-
name: client-javascript-utils-client-common
39-
path: clients/algoliasearch-client-javascript/packages/client-common/
40-
41-
- name: client-javascript-utils-requester-browser-xhr
42-
if: ${{ (inputs.javascript == 'true' && inputs.type == 'all') || inputs.type == 'js_utils' }}
43-
uses: actions/download-artifact@v3
44-
with:
45-
name: client-javascript-utils-requester-browser-xhr
46-
path: clients/algoliasearch-client-javascript/packages/requester-browser-xhr/
47-
48-
- name: client-javascript-utils-requester-node-http
49-
if: ${{ (inputs.javascript == 'true' && inputs.type == 'all') || inputs.type == 'js_utils' }}
50-
uses: actions/download-artifact@v3
51-
with:
52-
name: client-javascript-utils-requester-node-http
53-
path: clients/algoliasearch-client-javascript/packages/requester-node-http/
54-
55-
- name: client-javascript-utils-requester-fetch
56-
if: ${{ (inputs.javascript == 'true' && inputs.type == 'all') || inputs.type == 'js_utils' }}
57-
uses: actions/download-artifact@v3
58-
with:
59-
name: client-javascript-utils-requester-fetch
60-
path: clients/algoliasearch-client-javascript/packages/requester-fetch/
61-
6233
# JavaScript
6334
- name: Download clients-javascript artifact
6435
if: ${{ inputs.javascript == 'true' && inputs.type == 'all' }}

.github/workflows/check.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,6 @@ jobs:
168168
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
169169
run: cd clients/algoliasearch-client-javascript && yarn workspace @algolia/${{ matrix.client }} test
170170

171-
- name: Store '${{ matrix.client }}' JavaScript utils package
172-
uses: actions/upload-artifact@v3
173-
with:
174-
if-no-files-found: error
175-
name: client-javascript-utils-${{ matrix.client }}
176-
path: clients/algoliasearch-client-javascript/packages/${{ matrix.client }}
177-
178171
client_gen:
179172
timeout-minutes: 15
180173
runs-on: ubuntu-20.04
@@ -206,13 +199,6 @@ jobs:
206199
with:
207200
type: specs
208201

209-
# Always download the utils for js, in case they changed we want to include them in the zip
210-
- name: Download JavaScript utils artifacts
211-
if: ${{ matrix.client.language == 'javascript' }}
212-
uses: ./.github/actions/restore-artifacts
213-
with:
214-
type: js_utils
215-
216202
- name: Remove generated clients
217203
if: ${{ steps.cache.outputs.cache-hit != 'true' && matrix.client.language == 'javascript' && startsWith(env.head_ref, 'chore/prepare-release-') }}
218204
run: |

scripts/buildClients.ts

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable no-case-declarations */
2-
import { CI, run } from './common';
2+
import { run } from './common';
33
import { getClientsConfigField, getLanguageFolder } from './config';
44
import { createSpinner } from './oraLog';
55
import type { Generator, Language } from './types';
@@ -10,7 +10,7 @@ import type { Generator, Language } from './types';
1010
async function buildClient(
1111
language: Language,
1212
gens: Generator[],
13-
{ verbose, skipUtils }: { verbose: boolean; skipUtils: boolean }
13+
{ verbose }: { verbose: boolean; skipUtils: boolean }
1414
): Promise<void> {
1515
const cwd = getLanguageFolder(language);
1616
const spinner = createSpinner(`building '${language}'`, verbose).start();
@@ -23,17 +23,6 @@ async function buildClient(
2323
case 'php':
2424
break;
2525
case 'javascript':
26-
if (!CI && !skipUtils) {
27-
spinner.text = "building 'JavaScript' utils";
28-
29-
await run('yarn build:utils', {
30-
verbose: true,
31-
cwd,
32-
});
33-
}
34-
35-
spinner.text = "building 'JavaScript' clients";
36-
3726
const npmNamespace = getClientsConfigField('javascript', 'npmNamespace');
3827
const toRun = gens
3928
.map(({ additionalProperties: { packageName } }) =>

0 commit comments

Comments
 (0)