Merge branch 'main' into chore/build-js

Author: shortcuts

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.test.ts

@@ -28,7 +28,7 @@ describe('api', () => {
     })) as unknown as EchoResponse;
 
     expect(req.algoliaAgent).toMatchInlineSnapshot(
-      `"Algolia%20for%20JavaScript%20(${apiClientVersion});%20Search%20(${apiClientVersion});%20Node.js%20(${process.versions.node})"`
+      `"Algolia%20for%20JavaScript%20(${apiClientVersion})%3B%20Search%20(${apiClientVersion})%3B%20Node.js%20(${process.versions.node})"`
     );
   });
 

clients/algoliasearch-client-javascript/packages/client-common/src/createEchoRequester.ts

@@ -44,7 +44,7 @@ export function createEchoRequester({
       data: request.data ? JSON.parse(request.data) : undefined,
       path,
       host,
-      algoliaAgent: encodeURI(algoliaAgent),
+      algoliaAgent: encodeURIComponent(algoliaAgent),
       searchParams,
     };
 

clients/algoliasearch-client-javascript/packages/client-common/src/transporter/helpers.ts

@@ -49,11 +49,11 @@ export function serializeQueryParameters(parameters: QueryParameters): string {
   return Object.keys(parameters)
     .map(
       (key) =>
-        `${key}=${
+        `${key}=${encodeURIComponent(
           isObjectOrArray(parameters[key])
             ? JSON.stringify(parameters[key])
             : parameters[key]
-        }`
+        )}`
     )
     .join('&');
 }

playground/javascript/node/predict.ts

@@ -7,8 +7,7 @@ dotenv.config({ path: '../../.env' });
 const appId = process.env.ALGOLIA_PREDICT_APP_ID || '**** APP_ID *****';
 const apiKey =
   process.env.ALGOLIA_PREDICT_API_KEY || '**** PREDICT_API_KEY *****';
-
-const userId = 'user1';
+const userId = process.env.ALGOLIA_PREDICT_USER_ID || 'user1';
 
 // Init client with appId and apiKey
 const client = predictClient(appId, apiKey, 'ew');

templates/javascript/tests/client/suite.mustache

@@ -32,7 +32,7 @@ describe('{{testType}}', () => {
         {{> client/step}}
 
         {{#testUserAgent}}
-          expect(decodeURI(result.algoliaAgent)).toMatch(/{{{match}}}/);
+          expect(decodeURIComponent(result.algoliaAgent)).toMatch(/{{{match}}}/);
         {{/testUserAgent}}
         {{#testTimeouts}}
           expect(result).toEqual(expect.objectContaining({{{match.parameters}}}));

tests/output/javascript/yarn.lock

@@ -3663,7 +3663,7 @@ __metadata:
 
 "typescript@patch:[email protected]#~builtin<compat/typescript>":
   version: 4.7.4
-  resolution: "typescript@patch:typescript@npm%3A4.7.4#~builtin<compat/typescript>::version=4.7.4&hash=f456af"
+  resolution: "typescript@patch:typescript@npm%3A4.7.4#~builtin<compat/typescript>::version=4.7.4&hash=a1c5e5"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver