chore: additional changes

Author: cdhawke

specs/abtesting/common/schemas/ABTest.yml

@@ -155,9 +155,12 @@ MinimumDetectableEffect:
         Smallest difference in an observable metric between variants.
         For example, to detect a 10% difference between variants, set this value to 0.1.
     metric:
-      $ref: '#/Effect'
+      $ref: '#/Metric'
+  required:
+    - size
+    - metric
 
-Effect:
+Metric:
   type: string
   description: Metric for which you want to detect the smallest relative difference.
   enum:

specs/abtesting/common/schemas/EstimateResponse.yml

@@ -1,2 +1,22 @@
 EstimateResponse:
-  $ref: '../parameters.yml#/minimumDetectableEffect'
+  type: object
+  properties:
+    durationDays:
+      type: number
+      format: int64
+      description: Estimated number of days needed to reach the sample sizes required for detecting the configured effect. This value is based on historical traffic.
+      example: 21
+    controlSampleSize:
+      type: number
+      format: int64
+      description: Number of tracked searches needed to be able to detect the configured effect for the control variant.
+      example: 23415
+    experimentSampleSize:
+      type: number
+      format: int64
+      description: Number of tracked searches needed to be able to detect the configured effect for the experiment variant.
+      example: 23415
+  required:
+    - durationDays
+    - controlSampleSize
+    - experimentSampleSize

specs/abtesting/paths/estimate.yml

@@ -11,12 +11,23 @@ post:
     content:
       application/json:
         schema:
-          title: estimateABTestRequest
+          title: estimateRequest
           type: object
           additionalProperties: false
           properties:
             configuration:
-              $ref: '../common/schemas/ABTest.yml#/ABTestConfiguration'
+              title: configuration
+              type: object
+              description: A/B test configuration.
+              properties:
+                outliers:
+                  $ref: '../common/schemas/ABTest.yml#/Outliers'
+                emptySearch:
+                  $ref: '../common/schemas/ABTest.yml#/EmptySearch'
+                minimumDetectableEffect:
+                  $ref: '../common/schemas/ABTest.yml#/MinimumDetectableEffect'
+              required:
+                - minimumDetectableEffect
             variants:
               type: array
               description: A/B test variants.

tests/CTS/requests/abtesting/estimateABTest.json

@@ -1,7 +1,27 @@
 [
   {
     "testName": "estimate AB Test sample size",
-    "parameters": {},
+    "parameters": {
+      "configuration": {
+        "emptySearch": {
+          "exclude": true
+        },
+        "minimumDetectableEffect": {
+          "size": 0.03,
+          "metric": "conversionrate"
+        }
+      },
+      "variants": [
+        {
+          "index": "AB_TEST_1",
+          "trafficPercentage": 50
+        },
+        {
+          "index": "AB_TEST_2",
+          "trafficPercentage": 50
+        }
+      ]
+    },
     "request": {
       "path": "/2/abtests/estimate",
       "method": "POST",