Skip to content

Commit c1e7505

Browse files
Merge branch 'main' into fix/get-objects-response (generated)
Co-authored-by: Clément Vannicatte <[email protected]>
1 parent e95e085 commit c1e7505

File tree

39 files changed

+265
-200
lines changed

39 files changed

+265
-200
lines changed

clients/algoliasearch-client-csharp/algoliasearch/Models/Search/GetObjectsResponse.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,15 @@ public partial class GetObjectsResponse<T>
1919
/// <summary>
2020
/// Initializes a new instance of the GetObjectsResponse class.
2121
/// </summary>
22-
public GetObjectsResponse()
22+
[JsonConstructor]
23+
public GetObjectsResponse() { }
24+
/// <summary>
25+
/// Initializes a new instance of the GetObjectsResponse class.
26+
/// </summary>
27+
/// <param name="results">Retrieved records. (required).</param>
28+
public GetObjectsResponse(List<T> results)
2329
{
30+
Results = results ?? throw new ArgumentNullException(nameof(results));
2431
}
2532

2633
/// <summary>

clients/algoliasearch-client-dart/packages/client_search/lib/src/model/get_objects_response.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ part 'get_objects_response.g.dart';
99
final class GetObjectsResponse {
1010
/// Returns a new [GetObjectsResponse] instance.
1111
const GetObjectsResponse({
12-
this.results,
12+
required this.results,
1313
});
1414

1515
/// Retrieved records.
1616
@JsonKey(name: r'results')
17-
final List<Object>? results;
17+
final List<Object> results;
1818

1919
@override
2020
bool operator ==(Object other) =>

clients/algoliasearch-client-dart/packages/client_search/lib/src/model/get_objects_response.g.dart

Lines changed: 5 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/abtesting/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/analytics/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/ingestion/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/insights/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/monitoring/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/personalization/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/query-suggestions/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/recommend/client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-go/algolia/search/model_get_objects_response.go

Lines changed: 10 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/algoliasearch-client-java/algoliasearch/src/main/java/com/algolia/model/search/GetObjectsResponse.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,20 @@
1313
public class GetObjectsResponse<T> {
1414

1515
@JsonProperty("results")
16-
private List<T> results;
16+
private List<T> results = new ArrayList<>();
1717

1818
public GetObjectsResponse<T> setResults(List<T> results) {
1919
this.results = results;
2020
return this;
2121
}
2222

2323
public GetObjectsResponse<T> addResults(T resultsItem) {
24-
if (this.results == null) {
25-
this.results = new ArrayList<>();
26-
}
2724
this.results.add(resultsItem);
2825
return this;
2926
}
3027

3128
/** Retrieved records. */
32-
@javax.annotation.Nullable
29+
@javax.annotation.Nonnull
3330
public List<T> getResults() {
3431
return results;
3532
}

clients/algoliasearch-client-javascript/packages/client-search/model/getObjectsResponse.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ export type GetObjectsResponse<T = Record<string, unknown>> = {
44
/**
55
* Retrieved records.
66
*/
7-
results?: T[];
7+
results: T[];
88
};

clients/algoliasearch-client-kotlin/client/src/commonMain/kotlin/com/algolia/client/model/search/GetObjectsResponse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ import kotlinx.serialization.json.*
1313
public data class GetObjectsResponse(
1414

1515
/** Retrieved records. */
16-
@SerialName(value = "results") val results: List<JsonObject>? = null,
16+
@SerialName(value = "results") val results: List<JsonObject>,
1717
)

clients/algoliasearch-client-php/lib/Api/AbtestingClient.php

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66

77
use Algolia\AlgoliaSearch\Algolia;
88
use Algolia\AlgoliaSearch\Configuration\AbtestingConfig;
9+
use Algolia\AlgoliaSearch\Model\Abtesting\ABTest;
10+
use Algolia\AlgoliaSearch\Model\Abtesting\ABTestResponse;
911
use Algolia\AlgoliaSearch\Model\Abtesting\AddABTestsRequest;
12+
use Algolia\AlgoliaSearch\Model\Abtesting\ListABTestsResponse;
13+
use Algolia\AlgoliaSearch\Model\Abtesting\ScheduleABTestResponse;
1014
use Algolia\AlgoliaSearch\Model\Abtesting\ScheduleABTestsRequest;
1115
use Algolia\AlgoliaSearch\ObjectSerializer;
1216
use Algolia\AlgoliaSearch\RetryStrategy\ApiWrapper;
@@ -124,7 +128,7 @@ public function setClientApiKey($apiKey)
124128
*
125129
* @param array $requestOptions the requestOptions to send along with the query, they will be merged with the transporter requestOptions
126130
*
127-
* @return \Algolia\AlgoliaSearch\Model\Abtesting\ABTestResponse|array<string, mixed>
131+
* @return ABTestResponse|array<string, mixed>
128132
*/
129133
public function addABTests($addABTestsRequest, $requestOptions = [])
130134
{
@@ -310,7 +314,7 @@ public function customPut($path, $parameters = null, $body = null, $requestOptio
310314
* @param int $id Unique A/B test identifier. (required)
311315
* @param array $requestOptions the requestOptions to send along with the query, they will be merged with the transporter requestOptions
312316
*
313-
* @return \Algolia\AlgoliaSearch\Model\Abtesting\ABTestResponse|array<string, mixed>
317+
* @return ABTestResponse|array<string, mixed>
314318
*/
315319
public function deleteABTest($id, $requestOptions = [])
316320
{
@@ -347,7 +351,7 @@ public function deleteABTest($id, $requestOptions = [])
347351
* @param int $id Unique A/B test identifier. (required)
348352
* @param array $requestOptions the requestOptions to send along with the query, they will be merged with the transporter requestOptions
349353
*
350-
* @return \Algolia\AlgoliaSearch\Model\Abtesting\ABTest|array<string, mixed>
354+
* @return ABTest|array<string, mixed>
351355
*/
352356
public function getABTest($id, $requestOptions = [])
353357
{
@@ -387,7 +391,7 @@ public function getABTest($id, $requestOptions = [])
387391
* @param string $indexSuffix Index name suffix. Only A/B tests for indices ending with this string are included in the response. (optional)
388392
* @param array $requestOptions the requestOptions to send along with the query, they will be merged with the transporter requestOptions
389393
*
390-
* @return \Algolia\AlgoliaSearch\Model\Abtesting\ListABTestsResponse|array<string, mixed>
394+
* @return array<string, mixed>|ListABTestsResponse
391395
*/
392396
public function listABTests($offset = null, $limit = null, $indexPrefix = null, $indexSuffix = null, $requestOptions = [])
393397
{
@@ -431,7 +435,7 @@ public function listABTests($offset = null, $limit = null, $indexPrefix = null,
431435
*
432436
* @param array $requestOptions the requestOptions to send along with the query, they will be merged with the transporter requestOptions
433437
*
434-
* @return \Algolia\AlgoliaSearch\Model\Abtesting\ScheduleABTestResponse|array<string, mixed>
438+
* @return array<string, mixed>|ScheduleABTestResponse
435439
*/
436440
public function scheduleABTest($scheduleABTestsRequest, $requestOptions = [])
437441
{
@@ -459,7 +463,7 @@ public function scheduleABTest($scheduleABTestsRequest, $requestOptions = [])
459463
* @param int $id Unique A/B test identifier. (required)
460464
* @param array $requestOptions the requestOptions to send along with the query, they will be merged with the transporter requestOptions
461465
*
462-
* @return \Algolia\AlgoliaSearch\Model\Abtesting\ABTestResponse|array<string, mixed>
466+
* @return ABTestResponse|array<string, mixed>
463467
*/
464468
public function stopABTest($id, $requestOptions = [])
465469
{

0 commit comments

Comments
 (0)