review

Author: shortcuts

generators/src/main/java/com/algolia/codegen/AlgoliaJavaScriptGenerator.java

@@ -112,9 +112,9 @@ private void setDefaultGeneratorOptions() {
     additionalProperties.put("algoliaAgent", Utils.capitalize(CLIENT));
     additionalProperties.put("gitRepoId", "algoliasearch-client-javascript");
     additionalProperties.put("isSearchClient", CLIENT.equals("search"));
+    additionalProperties.put("isAlgoliasearchClient", isAlgoliasearchClient);
 
     if (isAlgoliasearchClient) {
-      additionalProperties.put("isAlgoliasearchClient", isAlgoliasearchClient);
       additionalProperties.put("analyticsVersion", Utils.getOpenApiToolsField("javascript", "analytics", "packageVersion"));
       additionalProperties.put("personalizationVersion", Utils.getOpenApiToolsField("javascript", "personalization", "packageVersion"));
       additionalProperties.put("searchVersion", Utils.getOpenApiToolsField("javascript", "search", "packageVersion"));

scripts/ci/githubActions/createMatrix.ts

@@ -86,8 +86,6 @@ async function getClientMatrix(baseBranch: string): Promise<void> {
     let testsToStore = testsToDelete;
 
     switch (language) {
-      case 'javascript':
-        break;
       case 'java':
         testsToStore = `${testsToDelete} ${testsRootFolder}/build.gradle`;
         break;

scripts/cli/utils.ts

@@ -99,7 +99,7 @@ export async function prompt({
     }
   } else {
     clientArg.forEach((client) => {
-      if (!decision.clientList.includes(client)) {
+      if (![ALL, ...decision.clientList].includes(client)) {
         throw new Error(
           `The '${clientArg}' client does not exist for ${
             decision.language