not working

Author: millotp

clients/algoliasearch-client-javascript/packages/client-common/package.json

@@ -30,7 +30,7 @@
   "scripts": {
     "build": "yarn clean && yarn tsup",
     "clean": "rm -rf ./dist || true",
-    "test": "vitest --run",
+    "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run",
     "test:bundle": "publint . && attw --pack ."
   },
   "devDependencies": {

clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/cache/browser-local-storage-cache.test.ts

@@ -91,7 +91,7 @@ describe('browser local storage cache', () => {
 
     await cache.clear();
 
-    const defaultValue = (): Promise<void> => Promise.resolve({ bar: 2 });
+    const defaultValue = (): Promise<{ bar: number }> => Promise.resolve({ bar: 2 });
 
     expect(localStorage.length).toBe(0);
 

clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/create-iterable-promise.test.ts

@@ -53,6 +53,26 @@ describe('createIterablePromise', () => {
       await expect(promise).resolves.toEqual(3);
       expect(calls).toBe(3);
     });
+
+    test('allow async function', async () => {
+      createIterablePromise({
+        func: () => {
+          return Promise.resolve({
+            hits: [],
+            cursor: '',
+          });
+        },
+        validate: async () => {
+          return await Promise.resolve(true);
+        },
+        aggregator: async (res) => {
+          return await Promise.resolve(res);
+        },
+        timeout: async () => {
+          return await Promise.resolve(1000);
+        },
+      });
+    });
   });
 
   describe('aggregator', () => {

clients/algoliasearch-client-javascript/packages/client-common/tsconfig.json

@@ -2,8 +2,9 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "types": ["node", "vitest/globals"],
-    "outDir": "dist"
+    "outDir": "dist",
+    "skipLibCheck": true
   },
   "include": ["src"],
-  "exclude": ["dist", "node_modules", "src/__tests__"]
+  "exclude": ["dist", "node_modules"]
 }

clients/algoliasearch-client-javascript/packages/logger-console/package.json

@@ -30,7 +30,7 @@
   "scripts": {
     "build": "yarn clean && yarn tsup",
     "clean": "rm -rf ./dist || true",
-    "test": "vitest --run",
+    "test": "tsc --noEmit__tests__/* && vitest --run",
     "test:bundle": "publint . && attw --pack ."
   },
   "devDependencies": {

clients/algoliasearch-client-javascript/packages/logger-console/tsconfig.json

@@ -2,8 +2,9 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "types": ["node", "vitest/globals"],
-    "outDir": "dist"
+    "outDir": "dist",
+    "skipLibCheck": true
   },
   "include": ["src", "index.ts"],
-  "exclude": ["dist", "node_modules", "src/__tests__"]
+  "exclude": ["dist", "node_modules"]
 }

clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json

@@ -27,7 +27,7 @@
   "scripts": {
     "build": "yarn clean && yarn tsup",
     "clean": "rm -rf ./dist || true",
-    "test": "vitest --run",
+    "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run",
     "test:bundle": "publint . && attw --pack . --ignore-rules cjs-resolves-to-esm"
   },
   "dependencies": {

clients/algoliasearch-client-javascript/packages/requester-browser-xhr/src/__tests__/browser-xhr-requester.test.ts

@@ -114,7 +114,7 @@ describe('timeout handling', () => {
 
   afterAll(
     () =>
-      new Promise((done) => {
+      new Promise<void>((done) => {
         done();
       }),
   );

clients/algoliasearch-client-javascript/packages/requester-browser-xhr/tsconfig.json

@@ -2,8 +2,9 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "types": ["node", "vitest/globals"],
-    "outDir": "dist"
+    "outDir": "dist",
+    "skipLibCheck": true
   },
   "include": ["src"],
-  "exclude": ["dist", "node_modules", "src/__tests__"]
+  "exclude": ["dist", "node_modules"]
 }

clients/algoliasearch-client-javascript/packages/requester-fetch/package.json

@@ -43,7 +43,7 @@
   "scripts": {
     "build": "yarn clean && yarn tsup",
     "clean": "rm -rf ./dist || true",
-    "test": "vitest --run",
+    "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run",
     "test:bundle": "publint . && attw --pack ."
   },
   "dependencies": {

clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts

@@ -108,7 +108,7 @@ describe('timeout handling', () => {
 
   afterAll(
     () =>
-      new Promise((done) => {
+      new Promise<void>((done) => {
         done();
       }),
   );

clients/algoliasearch-client-javascript/packages/requester-fetch/tsconfig.json

@@ -2,8 +2,9 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "types": ["node", "vitest/globals"],
-    "outDir": "dist"
+    "outDir": "dist",
+    "skipLibCheck": true
   },
   "include": ["src"],
-  "exclude": ["dist", "node_modules", "src/__tests__"]
+  "exclude": ["dist", "node_modules"]
 }

clients/algoliasearch-client-javascript/packages/requester-node-http/package.json

@@ -30,7 +30,7 @@
   "scripts": {
     "build": "yarn clean && yarn tsup",
     "clean": "rm -rf ./dist || true",
-    "test": "vitest --run",
+    "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run",
     "test:bundle": "publint . && attw --pack ."
   },
   "dependencies": {

clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts

@@ -164,7 +164,7 @@ describe('timeout handling', () => {
 
   afterAll(
     () =>
-      new Promise((done) => {
+      new Promise<void>((done) => {
         done();
       }),
   );

clients/algoliasearch-client-javascript/packages/requester-node-http/tsconfig.json

@@ -2,8 +2,9 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "types": ["node", "vitest/globals"],
-    "outDir": "dist"
+    "outDir": "dist",
+    "skipLibCheck": true
   },
   "include": ["src"],
-  "exclude": ["dist", "node_modules", "src/__tests__"]
+  "exclude": ["dist", "node_modules"]
 }

playground/javascript/node/ingestion.ts

@@ -1,4 +1,4 @@
-import { ApiError } from '@algolia/client-common';
+import { ApiError, createIterablePromise } from '@algolia/client-common';
 import { ingestionClient } from '@algolia/ingestion';
 
 const appId = process.env.ALGOLIA_APPLICATION_ID || '**** APP_ID *****';

templates/javascript/clients/package.mustache

@@ -11,7 +11,7 @@
     "build": "yarn clean && yarn tsup && yarn rollup -c rollup.config.js",
     "clean": "rm -rf ./dist || true",
     {{#isAlgoliasearchClient}}
-    "test": "vitest --run",
+    "test": "tsc --noEmit && vitest --run",
     {{/isAlgoliasearchClient}}
     "test:bundle": "publint . && attw --pack ."
   },