Skip to content

Commit cdad0fa

Browse files
committed
fix: default to __version__
1 parent ed4bd3e commit cdad0fa

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

clients/algoliasearch-client-python/algoliasearch/http/base_config.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def __init__(self, app_id: Optional[str] = None, api_key: Optional[str] = None):
2828
self.proxies: Optional[Dict[str, str]] = None
2929
self.hosts: Optional[HostsCollection] = None
3030

31-
self.user_agent: UserAgent = UserAgent()
31+
self._user_agent: UserAgent = UserAgent()
3232

3333
def set_client_api_key(self, api_key: str) -> None:
3434
"""Sets a new API key to authenticate requests."""
@@ -39,7 +39,7 @@ def set_client_api_key(self, api_key: str) -> None:
3939

4040
def add_user_agent(self, segment: str, version: Optional[str] = None) -> None:
4141
"""adds a segment to the default user agent, and update the headers sent with each requests as well"""
42-
self.user_agent = self.user_agent.add(segment, version)
42+
self._user_agent = self._user_agent.add(segment, version)
4343

4444
if self.headers is not None:
45-
self.headers["user-agent"] = self.user_agent.get()
45+
self.headers["user-agent"] = self._user_agent.get()

clients/algoliasearch-client-python/algoliasearch/http/user_agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ def get(self) -> str:
2020
return self.value
2121

2222
def add(self, segment: str, version: Optional[str] = __version__) -> Self:
23-
self.value += "; {} ({})".format(segment, version)
23+
self.value += "; {} ({})".format(segment, __version__ if version is None else version)
2424
return self

playground/python/app/search.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def main():
1515
)
1616
client.add_user_agent("playground")
1717

18-
print("user_agent", client._config.user_agent.get())
18+
print("user_agent", client._config._user_agent.get())
1919
print("client initialized", client)
2020

2121
try:

templates/python/config.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class {{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}Config(BaseConfig):
1414
def __init__(self, app_id: Optional[str], api_key: Optional[str]{{#hasRegionalHost}}, region: {{#fallbackToAliasHost}}Optional[str] = None{{/fallbackToAliasHost}}{{^fallbackToAliasHost}}str = ""{{/fallbackToAliasHost}}{{/hasRegionalHost}}) -> None:
1515
super().__init__(app_id, api_key)
1616

17-
self.user_agent = UserAgent().add("{{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}")
17+
self._user_agent = UserAgent().add("{{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}")
1818

1919
if app_id is None or not app_id:
2020
raise ValueError("`app_id` is missing.")
@@ -25,7 +25,7 @@ class {{#lambda.pascalcase}}{{client}}{{/lambda.pascalcase}}Config(BaseConfig):
2525
self.headers = {
2626
"x-algolia-application-id": app_id,
2727
"x-algolia-api-key": api_key,
28-
"user-agent": self.user_agent.get(),
28+
"user-agent": self._user_agent.get(),
2929
"content-type": "application/json",
3030
}
3131

0 commit comments

Comments
 (0)