Merge branch 'main' into feat/helper-tests

Author: millotp

.github/actions/setup/action.yml

@@ -23,7 +23,7 @@ runs:
 
     - name: Validate gradle wrapper
       if: inputs.type != 'minimal'
-      uses: gradle/wrapper-validation-action@v3
+      uses: gradle/actions/wrapper-validation@v3
 
     - name: Setup gradle
       if: inputs.type != 'minimal'

.github/workflows/check.yml

@@ -143,58 +143,11 @@ jobs:
           name: specs
           path: ${{ fromJSON(needs.setup.outputs.SPECS_MATRIX).bundledPath }}
 
-  client_javascript_utils:
-    timeout-minutes: 10
-    runs-on: ubuntu-22.04
-    needs: setup
-    if: ${{ needs.setup.outputs.RUN_GEN_JAVASCRIPT == 'true' }}
-    strategy:
-      matrix:
-        client:
-          - client-common
-          - requester-browser-xhr
-          - requester-node-http
-          - requester-fetch
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Cache '${{ matrix.client }}' client folder
-        if: ${{ github.ref != 'refs/heads/main' }}
-        id: cache
-        uses: actions/cache@v4
-        with:
-          key: |
-            ${{ matrix.client }}-${{ hashFiles(
-              format('clients/algoliasearch-client-javascript/packages/{0}/**', matrix.client),
-              'clients/algoliasearch-client-javascript/yarn.lock'
-            )}}
-          path: clients/algoliasearch-client-javascript/packages/${{ matrix.client }}
-
-      - name: Remove generated clients
-        if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        run: cd clients/algoliasearch-client-javascript/packages && ls | grep -v -E "(client-common|requester-*)" | xargs rm -rf
-
-      - name: Setup
-        if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        uses: ./.github/actions/setup
-        with:
-          type: minimal
-          language: javascript
-
-      - name: Build '${{ matrix.client }}' client
-        if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        run: cd clients/algoliasearch-client-javascript && yarn build:many @algolia/${{ matrix.client }}
-
-      - name: Run tests for '${{ matrix.client }}'
-        if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        run: cd clients/algoliasearch-client-javascript && yarn workspace @algolia/${{ matrix.client }} test
-
   client_gen_javascript:
     timeout-minutes: 10
     runs-on: ubuntu-22.04
     needs:
       - setup
-      - client_javascript_utils
       - specs
       - scripts
     if: |
@@ -236,14 +189,13 @@ jobs:
       - name: Build clients
         run: ${{ fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).buildCommand }}
 
+      - name: Run common and requester tests
+        run: cd clients/algoliasearch-client-javascript && yarn test
+
       - name: Test JavaScript bundle size
         if: ${{ startsWith(env.head_ref, 'chore/prepare-release-') }}
         run: cd clients/algoliasearch-client-javascript && yarn test:size
 
-      - name: Run JavaScript 'algoliasearch' client tests
-        if: ${{ contains(fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).toRun,'algoliasearch') }}
-        run: cd clients/algoliasearch-client-javascript && yarn workspace algoliasearch test
-
       - name: Remove previous CTS output
         run: rm -rf ${{ fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).testsToDelete }}
 
@@ -373,7 +325,8 @@ jobs:
     runs-on: macos-latest
     needs:
       - setup
-      - client_gen
+      - specs
+      - scripts
     if: |
       always() &&
       startsWith(github.head_ref, 'chore/prepare-release-') &&

clients/algoliasearch-client-go/algolia/abtesting/client.go

@@ -2,47 +2,47 @@
   "files": [
     {
       "path": "packages/algoliasearch/dist/algoliasearch.umd.js",
-      "maxSize": "8.10KB"
+      "maxSize": "8.65KB"
     },
     {
       "path": "packages/algoliasearch/dist/lite/lite.umd.js",
-      "maxSize": "3.70KB"
+      "maxSize": "3.90KB"
     },
     {
       "path": "packages/client-abtesting/dist/client-abtesting.umd.js",
-      "maxSize": "3.90KB"
+      "maxSize": "4.05KB"
     },
     {
       "path": "packages/client-analytics/dist/client-analytics.umd.js",
-      "maxSize": "4.50KB"
+      "maxSize": "4.75KB"
     },
     {
       "path": "packages/client-insights/dist/client-insights.umd.js",
-      "maxSize": "3.65KB"
+      "maxSize": "3.90KB"
     },
     {
       "path": "packages/client-personalization/dist/client-personalization.umd.js",
-      "maxSize": "3.80KB"
+      "maxSize": "4.05KB"
     },
     {
       "path": "packages/client-query-suggestions/dist/client-query-suggestions.umd.js",
-      "maxSize": "3.85KB"
+      "maxSize": "4.05KB"
     },
     {
       "path": "packages/client-search/dist/client-search.umd.js",
-      "maxSize": "6.60KB"
+      "maxSize": "7.05KB"
     },
     {
       "path": "packages/ingestion/dist/ingestion.umd.js",
-      "maxSize": "5.05KB"
+      "maxSize": "5.20KB"
     },
     {
       "path": "packages/monitoring/dist/monitoring.umd.js",
-      "maxSize": "3.90KB"
+      "maxSize": "3.95KB"
     },
     {
       "path": "packages/recommend/dist/recommend.umd.js",
-      "maxSize": "3.95KB"
+      "maxSize": "4.10KB"
     }
   ]
 }

clients/algoliasearch-client-go/algolia/analytics/client.go

@@ -11,6 +11,7 @@
     "clean": "lerna run clean --include-dependencies",
     "release:bump": "lerna version ${0:-patch} --no-changelog --no-git-tag-version --no-push --exact --force-publish --yes",
     "release:publish": "tsc --project tsconfig.script.json && node dist/scripts/publish.js",
+    "test": "lerna run test",
     "test:size": "bundlesize"
   },
   "devDependencies": {

clients/algoliasearch-client-go/algolia/insights/client.go

@@ -118,7 +118,7 @@ describe('timeout handling', () => {
   beforeAll(() => {
     server = createTestServer();
 
-    server.listen('1111');
+    server.listen('1113');
   });
 
   afterAll((done) => {

clients/algoliasearch-client-go/algolia/monitoring/client.go

@@ -174,7 +174,7 @@ describe('timeout handling', () => {
   beforeAll(() => {
     server = createTestServer();
 
-    server.listen('1111');
+    server.listen('1112');
   });
 
   afterAll((done) => {

clients/algoliasearch-client-go/algolia/personalization/client.go

@@ -21,7 +21,7 @@ public struct FallbackParams: Codable, JSONEncodable {
     /// upper limits of the range (inclusive). - **Facet filters.** `<facet>:<value>` where `<facet>` is a facet
     /// attribute (case-sensitive) and `<value>` a facet value. - **Tag filters.** `_tags:<value>` or just `<value>`
     /// (case-sensitive). - **Boolean filters.** `<facet>: true | false`.  You can combine filters with `AND`, `OR`, and
-    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.
+    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.  
     /// **Not supported:** `facet:value OR num > 3`. - You can't use `NOT` with combinations of filters.   **Not
     /// supported:** `NOT(facet:value OR facet:value)` - You can't combine conjunctions (`AND`) with `OR`.   **Not
     /// supported:** `facet:value OR (facet:value AND facet:value)`  Use quotes around your filters, if the facet
@@ -221,7 +221,7 @@ public struct FallbackParams: Codable, JSONEncodable {
     /// matches.  - `singleWordSynonym`.   Single-word synonyms, such as \"NY/NYC\" are considered exact matches.  -
     /// `multiWordsSynonym`.   Multi-word synonyms, such as \"NY/New York\" are considered exact matches.
     public var alternativesAsExact: [RecommendAlternativesAsExact]?
-    /// Advanced search syntax features you want to support.  - `exactPhrase`.   Phrases in quotes must match exactly.
+    /// Advanced search syntax features you want to support.  - `exactPhrase`.   Phrases in quotes must match exactly.  
     /// For example, `sparkly blue \"iPhone case\"` only returns records with the exact string \"iPhone case\".  -
     /// `excludeWords`.   Query words prefixed with a `-` must not occur in a record.   For example, `search -engine`
     /// matches records that contain \"search\" but not \"engine\".  This setting only has an effect if `advancedSyntax`
@@ -261,7 +261,7 @@ public struct FallbackParams: Codable, JSONEncodable {
     /// attribute is determined by the order in the `searchableAttributes` setting.
     public var attributeCriteriaComputedByMinProximity: Bool?
     public var renderingContent: RecommendRenderingContent?
-    /// Whether this search will use [Dynamic Re-Ranking](https://www.algolia.com/doc/guides/algolia-ai/re-ranking/).
+    /// Whether this search will use [Dynamic Re-Ranking](https://www.algolia.com/doc/guides/algolia-ai/re-ranking/). 
     /// This setting only has an effect if you activated Dynamic Re-Ranking for this index in the Algolia dashboard.
     public var enableReRanking: Bool?
     public var reRankingApplyFilter: RecommendReRankingApplyFilter?

clients/algoliasearch-client-go/algolia/query-suggestions/client.go

@@ -16,7 +16,7 @@ public struct ParamsConsequence: Codable, JSONEncodable {
     /// upper limits of the range (inclusive). - **Facet filters.** `<facet>:<value>` where `<facet>` is a facet
     /// attribute (case-sensitive) and `<value>` a facet value. - **Tag filters.** `_tags:<value>` or just `<value>`
     /// (case-sensitive). - **Boolean filters.** `<facet>: true | false`.  You can combine filters with `AND`, `OR`, and
-    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.
+    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.  
     /// **Not supported:** `facet:value OR num > 3`. - You can't use `NOT` with combinations of filters.   **Not
     /// supported:** `NOT(facet:value OR facet:value)` - You can't combine conjunctions (`AND`) with `OR`.   **Not
     /// supported:** `facet:value OR (facet:value AND facet:value)`  Use quotes around your filters, if the facet

clients/algoliasearch-client-go/algolia/recommend/client.go

@@ -21,7 +21,7 @@ public struct RecommendBaseSearchParams: Codable, JSONEncodable {
     /// upper limits of the range (inclusive). - **Facet filters.** `<facet>:<value>` where `<facet>` is a facet
     /// attribute (case-sensitive) and `<value>` a facet value. - **Tag filters.** `_tags:<value>` or just `<value>`
     /// (case-sensitive). - **Boolean filters.** `<facet>: true | false`.  You can combine filters with `AND`, `OR`, and
-    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.
+    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.  
     /// **Not supported:** `facet:value OR num > 3`. - You can't use `NOT` with combinations of filters.   **Not
     /// supported:** `NOT(facet:value OR facet:value)` - You can't combine conjunctions (`AND`) with `OR`.   **Not
     /// supported:** `facet:value OR (facet:value AND facet:value)`  Use quotes around your filters, if the facet

clients/algoliasearch-client-go/algolia/search/client.go

@@ -19,7 +19,7 @@ public struct RecommendBaseSearchParamsWithoutQuery: Codable, JSONEncodable {
     /// upper limits of the range (inclusive). - **Facet filters.** `<facet>:<value>` where `<facet>` is a facet
     /// attribute (case-sensitive) and `<value>` a facet value. - **Tag filters.** `_tags:<value>` or just `<value>`
     /// (case-sensitive). - **Boolean filters.** `<facet>: true | false`.  You can combine filters with `AND`, `OR`, and
-    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.
+    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.  
     /// **Not supported:** `facet:value OR num > 3`. - You can't use `NOT` with combinations of filters.   **Not
     /// supported:** `NOT(facet:value OR facet:value)` - You can't combine conjunctions (`AND`) with `OR`.   **Not
     /// supported:** `facet:value OR (facet:value AND facet:value)`  Use quotes around your filters, if the facet

clients/algoliasearch-client-go/algolia/usage/client.go

@@ -14,7 +14,7 @@ public struct RecommendCondition: Codable, JSONEncodable {
     /// upper limits of the range (inclusive). - **Facet filters.** `<facet>:<value>` where `<facet>` is a facet
     /// attribute (case-sensitive) and `<value>` a facet value. - **Tag filters.** `_tags:<value>` or just `<value>`
     /// (case-sensitive). - **Boolean filters.** `<facet>: true | false`.  You can combine filters with `AND`, `OR`, and
-    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.
+    /// `NOT` operators with the following restrictions:  - You can only combine filters of the same type with `OR`.  
     /// **Not supported:** `facet:value OR num > 3`. - You can't use `NOT` with combinations of filters.   **Not
     /// supported:** `NOT(facet:value OR facet:value)` - You can't combine conjunctions (`AND`) with `OR`.   **Not
     /// supported:** `facet:value OR (facet:value AND facet:value)`  Use quotes around your filters, if the facet