fix(cts): add tests for HTML error

millotp · millotp · commit e81ddc135eee · 2024-11-18T15:20:55.000+01:00
diff --git a/scripts/cts/testServer/timeout.ts b/scripts/cts/testServer/timeout.ts
@@ -97,6 +97,11 @@ function addRoutes(app: express.Express): void {
 
     // no response, just hang
   });
+
+  app.get('/1/html-error', (req, res) => {
+    res.setHeader('Content-Type', 'text/html');
+    res.status(429).send('<html><body>429 Too Many Requests</body></html>');
+  });
 }
 
 export function timeoutServer(): Promise<Server> {
diff --git a/tests/CTS/client/ingestion/api.json b/tests/CTS/client/ingestion/api.json
@@ -0,0 +1,42 @@
+[
+  {
+    "testName": "can handle HTML error",
+    "autoCreateClient": false,
+    "steps": [
+      {
+        "type": "createClient",
+        "parameters": {
+          "appId": "test-app-id",
+          "apiKey": "test-api-key",
+          "region": "us",
+          "customHosts": [
+            {
+              "port": 6676
+            }
+          ]
+        }
+      },
+      {
+        "type": "method",
+        "method": "customGet",
+        "parameters": {
+          "path": "1/html-error"
+        },
+        "expected": {
+          "error": {
+            "csharp": "<html><body>429 too many requests</body></html>",
+            "go": "API error [429] Too Many Requests",
+            "java": "Status Code: 429 - <html><body>429 Too Many Requests</body></html>",
+            "javascript": "<html><body>429 Too Many Requests</body></html>",
+            "kotlin": "Client request(GET http://%localhost%:6676/1/html-error) invalid: 429 Too Many Requests. Text: \"<html><body>429 Too Many Requests</body></html>\"",
+            "php": "json_decode error: Syntax error",
+            "python": "Too Many Requests",
+            "ruby": "unexpected token at '<html><body>429 Too Many Requests</body></html>'",
+            "scala": "<html><body>429 Too Many Requests</body></html>",
+            "swift": "HTTP error: Status code: 429 Message: No message"
+          }
+        }
+      }
+    ]
+  }
+]
diff --git a/tests/output/scala/src/test/scala/algoliasearch/package.scala b/tests/output/scala/src/test/scala/algoliasearch/package.scala
@@ -10,7 +10,10 @@ package object algoliasearch {
 
   def assertError(message: String)(call: => Unit)(implicit ec: ExecutionContextExecutor): Unit = {
     val error = intercept[Exception](call)
-    assert(error.getMessage == message)
+    assert(
+      error.getMessage == message,
+      s"Error message does not match, expected: $message, got: ${error.getMessage}"
+    )
   }
 
   @targetName("assertErrorFuture")
