Merge branch 'main' into fix/banner-link

Author: millotp

.github/actions/setup/action.yml

@@ -106,7 +106,7 @@ runs:
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.3
         echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
-        go install golang.org/x/tools/cmd/goimports@latest
+        go install golang.org/x/tools/cmd/goimports@v0.22.0
 
     - name: Cache golangci-lint analysis
       if: ${{ inputs.language == 'go' }}

clients/algoliasearch-client-go/go.mod

@@ -1,6 +1,6 @@
 module github.com/algolia/algoliasearch-client-go/v4
 
-go 1.21
+go 1.21.11
 
 require github.com/go-playground/validator/v10 v10.22.1
 

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.browser.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '../../client-common/src/types';

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.fetch.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '../../client-common/src/types';

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.node.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '../../client-common/src/types';

clients/algoliasearch-client-javascript/packages/algoliasearch/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/algoliasearch/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/node.cjs');

clients/algoliasearch-client-javascript/packages/algoliasearch/lite.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/lite/node';

clients/algoliasearch-client-javascript/packages/algoliasearch/lite.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/lite/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/algoliasearch/lite/builds/browser.ts

@@ -18,7 +18,6 @@ import { apiClientVersion, createLiteClient } from '../src/liteClient';
 export * from '../model';
 export { apiClientVersion } from '../src/liteClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function liteClient(appId: string, apiKey: string, options?: ClientOptions): LiteClient {
   if (!appId || typeof appId !== 'string') {
     throw new Error('`appId` is missing.');

clients/algoliasearch-client-javascript/packages/algoliasearch/lite/builds/node.ts

@@ -19,7 +19,6 @@ import { createLiteClient } from '../src/liteClient';
 export * from '../model';
 export { apiClientVersion } from '../src/liteClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function liteClient(appId: string, apiKey: string, options?: ClientOptions): LiteClient {
   if (!appId || typeof appId !== 'string') {
     throw new Error('`appId` is missing.');

clients/algoliasearch-client-javascript/packages/algoliasearch/lite/src/liteClient.ts

@@ -61,7 +61,6 @@ function getDefaultHosts(appId: string): Host[] {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createLiteClient({
   appId: appIdOption,
   apiKey: apiKeyOption,
@@ -214,7 +213,6 @@ export function createLiteClient({
           requests: getRecommendationsParams,
         };
 
-        // eslint-disable-next-line no-param-reassign
         getRecommendationsParams = newSignatureRequest;
       }
 
@@ -276,7 +274,6 @@ export function createLiteClient({
           }),
         };
 
-        // eslint-disable-next-line no-param-reassign
         searchMethodParams = newSignatureRequest;
       }
 

clients/algoliasearch-client-javascript/packages/algoliasearch/vitest.workspace.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineWorkspace } from 'vitest/config';
 
 export default defineWorkspace([

clients/algoliasearch-client-javascript/packages/client-abtesting/builds/browser.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/abtestingClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/abtestingClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function abtestingClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-abtesting/builds/fetch.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/abtestingClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/abtestingClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function abtestingClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-abtesting/builds/node.ts

@@ -21,7 +21,6 @@ import { Region, REGIONS } from '../src/abtestingClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/abtestingClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function abtestingClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-abtesting/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/client-abtesting/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/client-abtesting/src/abtestingClient.ts

@@ -40,7 +40,6 @@ function getDefaultHosts(region?: Region): Host[] {
   return [{ url, accept: 'readWrite', protocol: 'https' }];
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createAbtestingClient({
   appId: appIdOption,
   apiKey: apiKeyOption,

clients/algoliasearch-client-javascript/packages/client-analytics/builds/browser.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/analyticsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/analyticsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function analyticsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-analytics/builds/fetch.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/analyticsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/analyticsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function analyticsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-analytics/builds/node.ts

@@ -21,7 +21,6 @@ import { Region, REGIONS } from '../src/analyticsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/analyticsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function analyticsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-analytics/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/client-analytics/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/client-analytics/src/analyticsClient.ts

@@ -69,7 +69,6 @@ function getDefaultHosts(region?: Region): Host[] {
   return [{ url, accept: 'readWrite', protocol: 'https' }];
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createAnalyticsClient({
   appId: appIdOption,
   apiKey: apiKeyOption,

clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/logger/null-logger.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { describe, expect, test, vi } from 'vitest';
 
 import { createNullLogger } from '../../logger';

clients/algoliasearch-client-javascript/packages/client-common/vitest.workspace.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineWorkspace } from 'vitest/config';
 
 export default defineWorkspace([

clients/algoliasearch-client-javascript/packages/client-insights/builds/browser.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/insightsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/insightsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function insightsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-insights/builds/fetch.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/insightsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/insightsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function insightsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-insights/builds/node.ts

@@ -21,7 +21,6 @@ import { Region, REGIONS } from '../src/insightsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/insightsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function insightsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-insights/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/client-insights/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/client-insights/src/insightsClient.ts

@@ -32,7 +32,6 @@ function getDefaultHosts(region?: Region): Host[] {
   return [{ url, accept: 'readWrite', protocol: 'https' }];
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createInsightsClient({
   appId: appIdOption,
   apiKey: apiKeyOption,

clients/algoliasearch-client-javascript/packages/client-personalization/builds/browser.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/personalizationClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/personalizationClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function personalizationClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-personalization/builds/fetch.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/personalizationClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/personalizationClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function personalizationClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-personalization/builds/node.ts

@@ -21,7 +21,6 @@ import { Region, REGIONS } from '../src/personalizationClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/personalizationClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function personalizationClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-personalization/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/client-personalization/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/client-personalization/src/personalizationClient.ts

@@ -36,7 +36,6 @@ function getDefaultHosts(region: Region): Host[] {
   return [{ url, accept: 'readWrite', protocol: 'https' }];
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createPersonalizationClient({
   appId: appIdOption,
   apiKey: apiKeyOption,

clients/algoliasearch-client-javascript/packages/client-query-suggestions/builds/browser.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/querySuggestionsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/querySuggestionsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function querySuggestionsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-query-suggestions/builds/fetch.ts

@@ -20,7 +20,6 @@ import { Region, REGIONS } from '../src/querySuggestionsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/querySuggestionsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function querySuggestionsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-query-suggestions/builds/node.ts

@@ -21,7 +21,6 @@ import { Region, REGIONS } from '../src/querySuggestionsClient';
 export * from '../model';
 export { apiClientVersion, Region } from '../src/querySuggestionsClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function querySuggestionsClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/client-query-suggestions/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/client-query-suggestions/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/client-query-suggestions/src/querySuggestionsClient.ts

@@ -41,7 +41,6 @@ function getDefaultHosts(region: Region): Host[] {
   return [{ url, accept: 'readWrite', protocol: 'https' }];
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createQuerySuggestionsClient({
   appId: appIdOption,
   apiKey: apiKeyOption,

clients/algoliasearch-client-javascript/packages/client-search/builds/browser.ts

@@ -18,7 +18,6 @@ import { apiClientVersion, createSearchClient } from '../src/searchClient';
 export * from '../model';
 export { apiClientVersion } from '../src/searchClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function searchClient(appId: string, apiKey: string, options?: ClientOptions): SearchClient {
   if (!appId || typeof appId !== 'string') {
     throw new Error('`appId` is missing.');

clients/algoliasearch-client-javascript/packages/client-search/builds/fetch.ts

@@ -27,7 +27,6 @@ import {
 
 import { createHmac } from 'node:crypto';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function searchClient(appId: string, apiKey: string, options?: ClientOptions): SearchClient {
   if (!appId || typeof appId !== 'string') {
     throw new Error('`appId` is missing.');
@@ -78,7 +77,6 @@ export function searchClient(appId: string, apiKey: string, options?: ClientOpti
         .sort()
         .reduce(
           (acc, key) => {
-            // eslint-disable-next-line no-param-reassign
             acc[key] = (mergedRestrictions as any)[key];
             return acc;
           },

clients/algoliasearch-client-javascript/packages/client-search/builds/node.ts

@@ -28,7 +28,6 @@ import {
 
 import { createHmac } from 'node:crypto';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function searchClient(appId: string, apiKey: string, options?: ClientOptions): SearchClient {
   if (!appId || typeof appId !== 'string') {
     throw new Error('`appId` is missing.');
@@ -79,7 +78,6 @@ export function searchClient(appId: string, apiKey: string, options?: ClientOpti
         .sort()
         .reduce(
           (acc, key) => {
-            // eslint-disable-next-line no-param-reassign
             acc[key] = (mergedRestrictions as any)[key];
             return acc;
           },

clients/algoliasearch-client-javascript/packages/client-search/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/client-search/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/client-search/src/searchClient.ts

@@ -180,7 +180,6 @@ function getDefaultHosts(appId: string): Host[] {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createSearchClient({
   appId: appIdOption,
   apiKey: apiKeyOption,
@@ -2546,7 +2545,6 @@ export function createSearchClient({
           }),
         };
 
-        // eslint-disable-next-line no-param-reassign
         searchMethodParams = newSignatureRequest;
       }
 

clients/algoliasearch-client-javascript/packages/ingestion/builds/browser.ts

@@ -26,7 +26,6 @@ export {
   Region,
 } from '../src/ingestionClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function ingestionClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/ingestion/builds/fetch.ts

@@ -26,7 +26,6 @@ export {
   Region,
 } from '../src/ingestionClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function ingestionClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/ingestion/builds/node.ts

@@ -27,7 +27,6 @@ export {
   Region,
 } from '../src/ingestionClient';
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function ingestionClient(
   appId: string,
   apiKey: string,

clients/algoliasearch-client-javascript/packages/ingestion/index.d.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-unresolved
 export * from './dist/node';

clients/algoliasearch-client-javascript/packages/ingestion/index.js

@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-commonjs,import/extensions
 module.exports = require('./dist/builds/node.cjs');

clients/algoliasearch-client-javascript/packages/ingestion/src/ingestionClient.ts

@@ -158,7 +158,6 @@ export function isSubscriptionTrigger(trigger: TaskCreateTrigger | Trigger): tri
   return trigger.type === 'subscription';
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createIngestionClient({
   appId: appIdOption,
   apiKey: apiKeyOption,

clients/algoliasearch-client-javascript/packages/logger-console/src/__tests__/logger-console.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { beforeEach, describe, expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '@algolia/client-common';

clients/algoliasearch-client-javascript/packages/logger-console/src/logger.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import type { LogLevelType, Logger } from '@algolia/client-common';
 import { LogLevelEnum } from '@algolia/client-common';