Skip to content

feat(php): Change environment variables loading in the playground #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jun 14, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-487

Changes included:

  • Change environment variables loading in the PHP playground, now you can either use yarn docker playground php search which loads the .env file or directly run php search.php if you prefer use your local environment variables located in your .bashrc or whatever.

🧪 Test

yarn docker playground php search

@damcou damcou requested review from millotp and shortcuts June 14, 2022 14:08
@damcou damcou self-assigned this Jun 14, 2022
@damcou damcou marked this pull request as ready for review June 14, 2022 14:08
@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 3f19f51
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62a8964655f18c0009867794

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 14, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well, was it not working before ?

@damcou
Copy link
Contributor Author

damcou commented Jun 14, 2022

Seems to be working well, was it not working before ?

Indeed, I was just lazy and used my local env until now :s

@damcou damcou merged commit 833f8d4 into main Jun 14, 2022
@damcou damcou deleted the feat/APIC-487/update-php-playground branch June 14, 2022 14:30
@millotp
Copy link
Collaborator

millotp commented Jun 14, 2022

They are not set on my computer and it was working fine before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants