Skip to content

feat(javascript): use @algolia NPM namespace #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 4, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-559

Changes included:

As a next step into the public alpha phase, we need to change the NPM namespace to target the @algolia repository for sub clients, and algoliasearch namespace for the main client. The versions have also been updated to match their next major.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 4, 2022
@netlify
Copy link

netlify bot commented Jul 4, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit c9ab67f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62c442dfcc1c3f00080b29e6

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 4, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts force-pushed the feat/use-algolia-namespace branch from 762abd8 to 38ad593 Compare July 4, 2022 16:34
Base automatically changed from feat/js-algoliasearch-abtesting-dx to main July 5, 2022 09:04
@shortcuts shortcuts force-pushed the feat/use-algolia-namespace branch 2 times, most recently from b4d0d89 to f2a4006 Compare July 5, 2022 11:30
@shortcuts shortcuts force-pushed the feat/use-algolia-namespace branch from f2a4006 to 9768ce8 Compare July 5, 2022 13:05
@shortcuts shortcuts requested review from a team, damcou and millotp and removed request for a team July 5, 2022 13:40
@shortcuts shortcuts marked this pull request as ready for review July 5, 2022 13:40
@shortcuts shortcuts force-pushed the feat/use-algolia-namespace branch from 823f823 to c9ab67f Compare July 5, 2022 13:55
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's surprising the amount of change, but it looks way better like this !
Are we certain that renovate or upgrade tool won't automatically jump to the new version ?

@shortcuts
Copy link
Member Author

it's surprising the amount of change, but it looks way better like this ! Are we certain that renovate or upgrade tool won't automatically jump to the new version ?

It's a new major plus an alpha so it shouldn't be!

@shortcuts
Copy link
Member Author

Waiting on the confirmation from the predict team before merging this change

@shortcuts shortcuts merged commit df222d7 into main Jul 6, 2022
@shortcuts shortcuts deleted the feat/use-algolia-namespace branch July 6, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants