feat(javascript): add requester-fetch
#855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
damcou and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
approved these changes
Jul 21, 2022
| }, | ||
| }); | ||
| } catch (error) { | ||
| return { |
There was a problem hiding this comment.
doesn't 400 errors also end up here ? In that case we should have a status code
There was a problem hiding this comment.
doesn't 400 errors also end up here ?
Those errors are actually forwarded a bit below, in each requester there is this notion of global error that returns a 0 error, I don't have more context on this part but it seems to correctly forward 400s if you check the tests
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jul 21, 2022
algolia/api-clients-automation#855 Co-authored-by: Clément Vannicatte <[email protected]>
medicindev
pushed a commit
to medicindev/Algolia-Client--JavaScript
that referenced
this pull request
Mar 8, 2025
algolia/api-clients-automation#855 Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-572
Changes included:
Import
fetchrequester from the community implementation: algolia/algoliasearch-client-javascript#1411Only changes that were added from the first implementation are:
requesterOptionsSide changes
I've also moved the test utils to their own folder as it was becoming redundant
🧪 Test
CI :D