Skip to content

Commit 0d68faa

Browse files
committed
[Explain Dependency] Fix performance bug in -explain-module-dependency implementation
Embarrasingly, the code failed to query the already-'visited' set when traversing dependencies.
1 parent e413c5f commit 0d68faa

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Sources/SwiftDriver/ExplicitModuleBuilds/InterModuleDependencies/CommonDependencyOperations.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,8 @@ internal extension InterModuleDependencyGraph {
424424
}
425425

426426
for dependency in allDependencies {
427-
if try findAPath(source: dependency,
427+
if !visited.contains(dependency),
428+
try findAPath(source: dependency,
428429
pathSoFar: pathSoFar + [dependency],
429430
visited: &visited,
430431
result: &result,

0 commit comments

Comments
 (0)