Skip to content

Commit 6add58c

Browse files
committed
Fix tests
1 parent 7d5f460 commit 6add58c

File tree

1 file changed

+24
-25
lines changed

1 file changed

+24
-25
lines changed

test/callback_api.js

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -214,34 +214,33 @@ suite('sending messages', function() {
214214
});
215215
});
216216

217-
channel_test('saturate buffer', function(ch, done) {
217+
var channelOptions = {};
218+
219+
channel_test('find high watermark', function(ch, done) {
218220
var msg = randomString();
221+
var baseline = 0;
219222
ch.assertQueue('', {exclusive: true}, function(e, q) {
220223
if (e !== null) return done(e);
221-
let ok;
222-
for (let i = 0; i < 2047; i++) {
223-
ok = ch.sendToQueue(q.queue, Buffer.from(msg));
224-
if (!ok) break;
225-
}
226-
227-
assert.equal(ok, false);
224+
while (ch.sendToQueue(q.queue, Buffer.from(msg))) {
225+
baseline++;
226+
};
227+
channelOptions.highWaterMark = baseline * 2;
228228
done();
229-
});
229+
})
230230
});
231231

232-
channel_test('set high watermark (making it harder to saturate the buffer', { highWaterMark: 4092 }, function(ch, done) {
232+
channel_test('set high watermark', channelOptions, function(ch, done) {
233233
var msg = randomString();
234234
ch.assertQueue('', {exclusive: true}, function(e, q) {
235235
if (e !== null) return done(e);
236-
let ok;
237-
for (let i = 0; i < 4092; i++) {
236+
var ok;
237+
for (var i = 0; i < channelOptions.highWaterMark; i++) {
238238
ok = ch.sendToQueue(q.queue, Buffer.from(msg));
239239
assert.equal(ok, true);
240240
}
241241
done();
242242
});
243243
});
244-
245244
});
246245

247246
suite('ConfirmChannel', function() {
@@ -260,27 +259,27 @@ suite('ConfirmChannel', function() {
260259
ch.waitForConfirms(done);
261260
});
262261

263-
confirm_channel_test('saturate buffer', function(ch, done) {
262+
var channelOptions = {};
263+
264+
confirm_channel_test('find high watermark', function(ch, done) {
264265
var msg = randomString();
266+
var baseline = 0;
265267
ch.assertQueue('', {exclusive: true}, function(e, q) {
266268
if (e !== null) return done(e);
267-
let ok;
268-
for (let i = 0; i < 2047; i++) {
269-
ok = ch.sendToQueue(q.queue, Buffer.from(msg));
270-
if (!ok) break;
271-
}
272-
273-
assert.equal(ok, false);
269+
while (ch.sendToQueue(q.queue, Buffer.from(msg))) {
270+
baseline++;
271+
};
272+
channelOptions.highWaterMark = baseline * 2;
274273
done();
275-
});
274+
})
276275
});
277276

278-
confirm_channel_test('set high watermark (making it harder to saturate the buffer', { highWaterMark: 4092 }, function(ch, done) {
277+
confirm_channel_test('set high watermark', channelOptions, function(ch, done) {
279278
var msg = randomString();
280279
ch.assertQueue('', {exclusive: true}, function(e, q) {
281280
if (e !== null) return done(e);
282-
let ok;
283-
for (let i = 0; i < 4092; i++) {
281+
var ok;
282+
for (var i = 0; i < channelOptions.highWaterMark; i++) {
284283
ok = ch.sendToQueue(q.queue, Buffer.from(msg));
285284
assert.equal(ok, true);
286285
}

0 commit comments

Comments
 (0)