Skip to content

Commit fad069d

Browse files
author
Gael du Plessix
committed
refactor(AMD/CommonJS exported module): Export module name instead of module object
When the module is imported using AMD/CommonJS, it is expected to expose its name instead of the Angular module object. This is because angular.module() expects the dependencies as string instead of actual module objects. Fix #326. Breaking change: code that relies on the module object to be exported (accessing the name via `.name` for example) will break, since the name is now directly returned.
1 parent 6e8b022 commit fad069d

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

dist/rzslider.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*! angularjs-slider - v4.0.2 -
22
(c) Rafal Zajac <[email protected]>, Valentin Hervieu <[email protected]>, Jussi Saarivirta <[email protected]>, Angelin Sirbu <[email protected]> -
33
https://github.com/angular-slider/angularjs-slider -
4-
2016-06-29 */
4+
2016-06-30 */
55
.rzslider {
66
position: relative;
77
display: inline-block;

dist/rzslider.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*! angularjs-slider - v4.0.2 -
22
(c) Rafal Zajac <[email protected]>, Valentin Hervieu <[email protected]>, Jussi Saarivirta <[email protected]>, Angelin Sirbu <[email protected]> -
33
https://github.com/angular-slider/angularjs-slider -
4-
2016-06-29 */
4+
2016-06-30 */
55
/*jslint unparam: true */
66
/*global angular: false, console: false, define, module */
77
(function(root, factory) {
@@ -2108,5 +2108,5 @@
21082108

21092109
}]);
21102110

2111-
return module
2111+
return module.name
21122112
}));

dist/rzslider.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rzslider.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/rzslider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2105,5 +2105,5 @@
21052105

21062106
/*templateReplacement*/
21072107

2108-
return module
2108+
return module.name
21092109
}));

0 commit comments

Comments
 (0)