Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Commit a4c65e6

Browse files
authored
Cleanups: use bazelignore (#235)
Update to Bazel 0.19
1 parent 5fb7827 commit a4c65e6

File tree

4 files changed

+7
-17
lines changed

4 files changed

+7
-17
lines changed

.bazelignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# We use a docker image as the basis for our build, so that all the toolchains we use
55
# are already installed and the build can start running right away. It also guarantees
66
# the environment is portable and reproducible on your local machine.
7-
var_1: &docker_image angular/ngcontainer:0.7.0
7+
var_1: &docker_image angular/ngcontainer:0.8.0
88

99
# CircleCI lets us pick the key for storing one or more caches, to speed up subsequent builds.
1010
# We can use this to avoid re-fetching our dependencies from npm on every build.
@@ -13,7 +13,7 @@ var_1: &docker_image angular/ngcontainer:0.7.0
1313
# - the branch we are on, which really shouldn't be needed since the yarn lock file should be hermetic
1414
# - the docker image tag, working around an issue we saw where changing docker images causes permission
1515
# errors when restoring the cache, like when the user we run as changes
16-
var_2: &cache_key angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.7.0
16+
var_2: &cache_key angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.8.0
1717

1818
# Each job will inherit these defaults
1919
anchor_1: &job_defaults

BUILD.bazel

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
alias(
4-
name = "install",
5-
actual = "@nodejs//:yarn",
6-
)
7-
83
# ts_library and ng_module use the `//:tsconfig.json` target
94
# by default. This alias allows omitting explicit tsconfig
105
# attribute.

WORKSPACE

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,6 @@ http_archive(
5050
strip_prefix = "rules_sass-1.14.1",
5151
)
5252

53-
# This local_repository rule is needed to prevent `bazel build ...` from
54-
# drilling down into the @rxjs workspace BUILD files in node_modules/rxjs/src.
55-
# In the future this will no longer be needed.
56-
local_repository(
57-
name = "ignore_node_modules_rxjs",
58-
path = "node_modules/rxjs/src",
59-
)
60-
6153
####################################
6254
# Load and install our dependencies downloaded above.
6355

@@ -67,8 +59,10 @@ rules_angular_dependencies()
6759

6860
load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "node_repositories", "yarn_install")
6961

70-
# The minimum bazel version to use with this example repo is 0.17.1
71-
check_bazel_version("0.17.1")
62+
# The minimum bazel version to use with this example repo
63+
# Bazel 0.19 supports the .bazelignore file
64+
check_bazel_version("0.19.0")
65+
7266
node_repositories(
7367
node_version = "10.9.0",
7468
yarn_version = "1.9.2",

0 commit comments

Comments
 (0)