Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Commit c5f8750

Browse files
gregmagolanalexeagle
authored andcommitted
Update to rules_nodejs 0.10.0 (#151)
* Update to rules_nodejs 0.10.0 * Update to ngcontainer 0.3.1 for bazel 0.14.0 and update buildifier dep * Ran buildifier
1 parent 74b2536 commit c5f8750

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# We use a docker image as the basis for our build, so that all the toolchains we use
55
# are already installed and the build can start running right away. It also guarantees
66
# the environment is portable and reproducible on your local machine.
7-
var_1: &docker_image angular/ngcontainer:0.3.0
7+
var_1: &docker_image angular/ngcontainer:0.3.1
88

99
# CircleCI lets us pick the key for storing one or more caches, to speed up subsequent builds.
1010
# We can use this to avoid re-fetching our dependencies from npm on every build.
@@ -13,7 +13,7 @@ var_1: &docker_image angular/ngcontainer:0.3.0
1313
# - the branch we are on, which really shouldn't be needed since the yarn lock file should be hermetic
1414
# - the docker image tag, working around an issue we saw where changing docker images causes permission
1515
# errors when restoring the cache, like when the user we run as changes
16-
var_2: &cache_key angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.3.0
16+
var_2: &cache_key angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.3.1
1717

1818
# Each job will inherit these defaults
1919
anchor_1: &job_defaults

WORKSPACE

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,22 @@ workspace(name = "angular_bazel_example")
1414
# Allows Bazel to run tooling in Node.js
1515
http_archive(
1616
name = "build_bazel_rules_nodejs",
17-
url = "https://github.com/bazelbuild/rules_nodejs/archive/0.9.1.zip",
18-
strip_prefix = "rules_nodejs-0.9.1",
19-
sha256 = "6139762b62b37c1fd171d7f22aa39566cb7dc2916f0f801d505a9aaf118c117f",
17+
urls = ["https://github.com/bazelbuild/rules_nodejs/archive/0.10.0.zip"],
18+
strip_prefix = "rules_nodejs-0.10.0",
19+
sha256 = "2f77623311da8b5009b1c7eade12de8e15fa3cd2adf9dfcc9f87cb2082b2211f",
2020
)
2121

2222
# The Bazel buildtools repo contains tools like the BUILD file formatter, buildifier
23+
# This commit matches the version of buildifier in angular/ngcontainer
24+
# If you change this, also check if it matches the version in the angular/ngcontainer
25+
# version in /.circleci/config.yml
26+
BAZEL_BUILDTOOLS_VERSION = "82b21607e00913b16fe1c51bec80232d9d6de31c"
27+
2328
http_archive(
2429
name = "com_github_bazelbuild_buildtools",
25-
# Note, this commit matches the version of buildifier in angular/ngcontainer
26-
url = "https://github.com/bazelbuild/buildtools/archive/b3b620e8bcff18ed3378cd3f35ebeb7016d71f71.zip",
27-
strip_prefix = "buildtools-b3b620e8bcff18ed3378cd3f35ebeb7016d71f71",
28-
sha256 = "dad19224258ed67cbdbae9b7befb785c3b966e5a33b04b3ce58ddb7824b97d73",
30+
url = "https://github.com/bazelbuild/buildtools/archive/%s.zip" % BAZEL_BUILDTOOLS_VERSION,
31+
strip_prefix = "buildtools-%s" % BAZEL_BUILDTOOLS_VERSION,
32+
sha256 = "edb24c2f9c55b10a820ec74db0564415c0cf553fa55e9fc709a6332fb6685eff",
2933
)
3034

3135
# Runs the TypeScript compiler

src/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ ts_devserver(
3737
deps = ["//src"],
3838
)
3939

40-
load("@build_bazel_rules_nodejs//:defs.bzl", "rollup_bundle", "nodejs_binary")
40+
load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary", "rollup_bundle")
4141

4242
rollup_bundle(
4343
name = "bundle",

0 commit comments

Comments
 (0)