Remove dependency on local node_modules for @rxjs repository

gregmagolan · gregmagolan · commit fe25ee052620 · 2018-10-05T14:53:44.000-07:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -59,11 +59,6 @@ jobs:
       # to reproduce a failure.
       - run: bazel info release
 
-      # Install the dependencies from NPM
-      # TODO(gmagolan): Use `bazel run :install` once bootstrap issue resolved.
-      # See https://github.com/bazelbuild/rules_nodejs/issues/275.
-      - run: yarn
-
       # Build and Test
       - run: bazel test //...
 
diff --git a/WORKSPACE b/WORKSPACE
@@ -29,9 +29,11 @@ http_archive(
 )
 
 # The @rxjs repo contains targets for building rxjs with bazel
-local_repository(
+http_archive(
     name = "rxjs",
-    path = "node_modules/rxjs/src",
+    url = "https://registry.yarnpkg.com/rxjs/-/rxjs-6.3.3.tgz",
+    strip_prefix = "package/src",
+    sha256 = "72b0b4e517f43358f554c125e40e39f67688cd2738a8998b4a266981ed32f403",
 )
 
 ####################################
@@ -44,7 +46,6 @@ rules_angular_dependencies()
 load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories", "yarn_install")
 
 node_repositories(
-    preserve_symlinks = True,
     node_version = "10.9.0",
     yarn_version = "1.9.2",
 )

Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,11 @@ http_archive(`
`29`	`29`	`)`
`30`	`30`
`31`	`31`	`# The @rxjs repo contains targets for building rxjs with bazel`
`32`		`-local_repository(`
	`32`	`+http_archive(`
`33`	`33`	`name = "rxjs",`
`34`		`- path = "node_modules/rxjs/src",`
	`34`	`+ url = "https://registry.yarnpkg.com/rxjs/-/rxjs-6.3.3.tgz",`
	`35`	`+ strip_prefix = "package/src",`
	`36`	`+ sha256 = "72b0b4e517f43358f554c125e40e39f67688cd2738a8998b4a266981ed32f403",`
`35`	`37`	`)`
`36`	`38`
`37`	`39`	`####################################`
`@@ -44,7 +46,6 @@ rules_angular_dependencies()`
`44`	`46`	`load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories", "yarn_install")`
`45`	`47`
`46`	`48`	`node_repositories(`
`47`		`- preserve_symlinks = True,`
`48`	`49`	`node_version = "10.9.0",`
`49`	`50`	`yarn_version = "1.9.2",`
`50`	`51`	`)`