fix(@angular-devkit/schematics): upgrade refactoring with tslint emits too much whitespace

alan-agius4 · kyliau · commit 052904df9d6a · 2018-10-31T14:57:44.000-07:00
Fixes #12653
diff --git a/packages/angular_devkit/schematics/tasks/tslint-fix/executor.ts b/packages/angular_devkit/schematics/tasks/tslint-fix/executor.ts
@@ -182,7 +182,10 @@ export default function(): TaskExecutor<TslintFixTaskOptions> {
         }
         const formatter = new Formatter();
 
-        const output = formatter.format(result.failures, result.fixes);
+        // Certain tslint formatters outputs '\n' when there are no failures.
+        // This will bloat the console when having schematics running refactor tasks.
+        // see https://github.com/palantir/tslint/issues/4244
+        const output = (formatter.format(result.failures, result.fixes) || '').trim();
         if (output) {
           context.logger.info(output);
         }

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,10 @@ export default function(): TaskExecutor<TslintFixTaskOptions> {`
`182`	`182`	`}`
`183`	`183`	`const formatter = new Formatter();`
`184`	`184`
`185`		`- const output = formatter.format(result.failures, result.fixes);`
	`185`	`+ // Certain tslint formatters outputs '\n' when there are no failures.`
	`186`	`+ // This will bloat the console when having schematics running refactor tasks.`
	`187`	`+ // see https://github.com/palantir/tslint/issues/4244`
	`188`	`+ const output = (formatter.format(result.failures, result.fixes) \|\| '').trim();`
`186`	`189`	`if (output) {`
`187`	`190`	`context.logger.info(output);`
`188`	`191`	`}`