Skip to content

Commit 0c2f2f4

Browse files
Alanvikerman
Alan
authored andcommitted
feat(@ngtools/webpack): deprecate discoverLazyRoutes, additionalLazyModules and additionalLazyModuleResources options
String form of lazy loading and SystemJsNgModuleLoader are deprecated, and this is part of its usage. See: https://angular.io/api/core/SystemJsNgModuleLoader#systemjsngmoduleloader
1 parent 640ae2f commit 0c2f2f4

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

packages/ngtools/webpack/src/interfaces.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,22 @@ export interface AngularCompilerPluginOptions {
4545
logger?: logging.Logger;
4646
directTemplateLoading?: boolean;
4747

48-
// When using the loadChildren string syntax, @ngtools/webpack must query @angular/compiler-cli
49-
// via a private API to know which lazy routes exist. This increases build and rebuild time.
50-
// When using Ivy, the string syntax is not supported at all. Thus we shouldn't attempt that.
51-
// This option is also used for when the compilation doesn't need this sort of processing at all.
48+
/**
49+
* When using the loadChildren string syntax, @ngtools/webpack must query @angular/compiler-cli
50+
* via a private API to know which lazy routes exist. This increases build and rebuild time.
51+
* When using Ivy, the string syntax is not supported at all. Thus we shouldn't attempt that
52+
* This option is also used for when the compilation doesn't need this sort of processing at all.
53+
* @deprecated SystemJsNgModuleLoader is deprecated, and this is part of its usage.
54+
*/
5255
discoverLazyRoutes?: boolean;
5356

54-
// added to the list of lazy routes
57+
/** added to the list of lazy routes
58+
* @deprecated SystemJsNgModuleLoader is deprecated, and this is part of its usage.
59+
*/
5560
additionalLazyModules?: { [module: string]: string };
61+
/**
62+
* @deprecated SystemJsNgModuleLoader is deprecated, and this is part of its usage.
63+
*/
5664
additionalLazyModuleResources?: string[];
5765

5866
// The ContextElementDependency of correct Webpack compilation.

0 commit comments

Comments
 (0)