refactor(@angular-devkit/build-angular): remove BundleBudgetPlugin

Remove BundleBudgetPlugin, and instead use the `checkBudgets` method directly in the browser buillder.

Author: alan-agius4

packages/angular_devkit/build_angular/src/browser/index.ts

@@ -296,6 +296,7 @@ export function buildWebpackBrowser(
 
               return { success };
             } else {
+              const processResults: ProcessBundleResult[] = [];
               const bundleInfoStats: BundleStats[] = [];
               outputPaths = ensureOutputPaths(baseOutputPath, i18n);
 
@@ -445,7 +446,6 @@ export function buildWebpackBrowser(
 
                 const processActions: typeof actions = [];
                 let processRuntimeAction: ProcessBundleOptions | undefined;
-                const processResults: ProcessBundleResult[] = [];
                 for (const action of actions) {
                   // If SRI is enabled always process the runtime bundle
                   // Lazy route integrity values are stored in the runtime bundle
@@ -598,22 +598,6 @@ export function buildWebpackBrowser(
                   const asset = webpackStats.assets?.find(a => a.name === chunk.files[0]);
                   bundleInfoStats.push(generateBundleStats({ ...chunk, size: asset?.size }));
                 }
-
-                // Check for budget errors and display them to the user.
-                const budgets = options.budgets || [];
-                const budgetFailures = checkBudgets(budgets, webpackStats, processResults);
-                for (const { severity, message } of budgetFailures) {
-                  switch (severity) {
-                    case ThresholdSeverity.Warning:
-                      webpackStats.warnings.push(message);
-                      break;
-                    case ThresholdSeverity.Error:
-                      webpackStats.errors.push(message);
-                      break;
-                    default:
-                      assertNever(severity);
-                  }
-                }
               } else {
                 files = emittedFiles.filter(x => x.name !== 'polyfills-es5');
                 noModuleFiles = emittedFiles.filter(x => x.name === 'polyfills-es5');
@@ -636,6 +620,24 @@ export function buildWebpackBrowser(
                 }
               }
 
+              // Check for budget errors and display them to the user.
+              const budgets = options.budgets;
+              if (budgets?.length) {
+                const budgetFailures = checkBudgets(budgets, webpackStats, processResults);
+                for (const { severity, message } of budgetFailures) {
+                  switch (severity) {
+                    case ThresholdSeverity.Warning:
+                      webpackStats.warnings.push(message);
+                      break;
+                    case ThresholdSeverity.Error:
+                      webpackStats.errors.push(message);
+                      break;
+                    default:
+                      assertNever(severity);
+                  }
+                }
+              }
+
               // Copy assets
               if (!options.watch && options.assets?.length) {
                 spinner.start('Copying assets...');

packages/angular_devkit/build_angular/src/webpack/configs/common.ts

@@ -39,7 +39,6 @@ import { findAllNodeModules } from '../../utils/find-up';
 import { Spinner } from '../../utils/spinner';
 import { isWebpackFiveOrHigher, withWebpackFourOrFive } from '../../utils/webpack-version';
 import {
-  BundleBudgetPlugin,
   DedupeModuleResolvePlugin,
   NamedLazyChunksPlugin,
   OptimizeCssWebpackPlugin,
@@ -361,17 +360,6 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
     );
   }
 
-  if (buildOptions.budgets.length && !differentialLoadingMode) {
-    // Budgets are computed after differential builds, not via a plugin.
-    // https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/browser/index.ts
-    const extraEntryPoints = [
-      ...normalizeExtraEntryPoints(buildOptions.styles || [], 'styles'),
-      ...normalizeExtraEntryPoints(buildOptions.scripts || [], 'scripts'),
-    ];
-
-    extraPlugins.push(new BundleBudgetPlugin({ budgets: buildOptions.budgets, extraEntryPoints }));
-  }
-
   if ((scriptsSourceMap || stylesSourceMap)) {
     extraRules.push({
       test: /\.m?js$/,

packages/angular_devkit/build_angular/src/webpack/plugins/bundle-budget.ts

@@ -9,7 +9,6 @@
 // Exports the webpack plugins we use internally.
 export { AnyComponentStyleBudgetChecker } from './any-component-style-budget-checker';
 export { OptimizeCssWebpackPlugin, OptimizeCssWebpackPluginOptions } from './optimize-css-webpack-plugin';
-export { BundleBudgetPlugin, BundleBudgetPluginOptions } from './bundle-budget';
 export { ScriptsWebpackPlugin, ScriptsWebpackPluginOptions } from './scripts-webpack-plugin';
 export { SuppressExtractedTextChunksWebpackPlugin } from './suppress-entry-chunks-webpack-plugin';
 export { RemoveHashPlugin, RemoveHashPluginOptions } from './remove-hash-plugin';