test(@angular-devkit/build-ng-packagr): build and test with Bazel

Author: filipesilva

package.json

@@ -169,6 +169,7 @@
     "mini-css-extract-plugin": "0.9.0",
     "minimatch": "3.0.4",
     "minimist": "^1.2.0",
+    "ng-packagr": "~9.0.0",
     "node-fetch": "^2.2.0",
     "npm-registry-client": "8.6.0",
     "open": "7.0.3",

packages/angular_devkit/build_ng_packagr/BUILD.bazel

@@ -0,0 +1,114 @@
+# Copyright Google Inc. All Rights Reserved.
+#
+# Use of this source code is governed by an MIT-style license that can be
+# found in the LICENSE file at https://angular.io/license
+
+licenses(["notice"])  # MIT
+
+load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
+load("@npm_bazel_typescript//:index.bzl", "ts_library")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
+load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
+load("//tools:ts_json_schema.bzl", "ts_json_schema")
+
+package(default_visibility = ["//visibility:public"])
+
+ts_json_schema(
+    name = "schema",
+    src = "src/build/schema.json",
+)
+
+ts_library(
+    name = "build_ng_packagr",
+    srcs = glob(
+        include = ["src/**/*.ts"],
+        exclude = ["src/**/*_spec.ts"],
+    ) + [
+        "//packages/angular_devkit/build_ng_packagr:src/build/schema.ts",
+    ],
+    data = glob(
+        include = [
+            "package.json",
+            "builders.json",
+            "src/build/schema.json",
+        ],
+    ),
+    devmode_module = "commonjs",
+    devmode_target = "es2018",
+    module_name = "@angular-devkit/build-ng-packagr",
+    module_root = "src/index.d.ts",
+    deps = [
+        "//packages/angular_devkit/architect",
+        "@npm//@types/node",
+        "@npm//ng-packagr",
+        "@npm//rxjs",
+    ],
+)
+
+pkg_npm(
+    name = "npm_package",
+    deps = [
+        ":build_ng_packagr",
+    ],
+)
+
+pkg_tar(
+    name = "npm_package_archive",
+    srcs = [":npm_package"],
+    extension = "tar.gz",
+    strip_prefix = "./npm_package",
+    tags = ["manual"],
+)
+
+ts_library(
+    name = "build_ng_packagr_test_lib",
+    testonly = True,
+    srcs = glob(
+        include = [
+            "src/test-utils.ts",
+            "src/**/*_spec.ts",
+        ],
+    ),
+    data = glob(["test/**/*"]),
+    devmode_module = "commonjs",
+    devmode_target = "es2018",
+    tsconfig = "//:tsconfig-test.json",
+    deps = [
+        ":build_ng_packagr",
+        "//packages/angular_devkit/architect",
+        "//packages/angular_devkit/architect/node",
+        "//packages/angular_devkit/architect/testing",
+        "//packages/angular_devkit/core",
+        "@npm//@angular/common",
+        "@npm//@angular/compiler",
+        "@npm//@angular/compiler-cli",
+        "@npm//@angular/core",
+        "@npm//@angular/platform-browser",
+        "@npm//@angular/platform-browser-dynamic",
+        "@npm//@angular/router",
+        "@npm//@types/jasmine",
+        "@npm//@types/node",
+        "@npm//ng-packagr",
+        "@npm//rxjs",
+        "@npm//tslib",
+        "@npm//typescript",
+        "@npm//zone.js",
+    ],
+)
+
+jasmine_node_test(
+    name = "build_ng_packagr_test",
+    srcs = ["build_ng_packagr_test_lib"],
+    tags = ["cpu:2"],
+    templated_args = ["--nobazel_patch_module_resolver"],
+)
+
+jasmine_node_test(
+    name = "build_ng_packagr_ve_test",
+    srcs = ["build_ng_packagr_test_lib"],
+    tags = ["cpu:2"],
+    templated_args = [
+        "--nobazel_patch_module_resolver",
+        "view_engine",
+    ],
+)

packages/angular_devkit/build_ng_packagr/src/build/index_spec_large.ts renamed to packages/angular_devkit/build_ng_packagr/src/build/index_spec.ts

@@ -18,13 +18,12 @@ import {
 } from '@angular-devkit/core'; // tslint:disable-line:no-implicit-dependencies
 import { map, take, tap } from 'rxjs/operators';
 
-const veEnabled = process.argv.includes('--ve');
+// Default timeout for large specs is 2.5 minutes.
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 150000;
 
-const devkitRoot = (global as unknown as { _DevKitRoot: string})._DevKitRoot;
-const workspaceRoot = join(
-  normalize(devkitRoot),
-  `tests/angular_devkit/build_ng_packagr/ng-packaged${veEnabled ? '-ve' : ''}/`,
-);
+// This flag controls whether AOT compilation uses Ivy or View Engine (VE).
+export let veEnabled = process.argv.some(arg => arg == 'view_engine');
+export const workspaceRoot = join(normalize(__dirname), `../../test/ng-packaged/`);
 
 describe('NgPackagr Builder', () => {
   const host = new TestProjectHost(workspaceRoot);
@@ -48,6 +47,11 @@ describe('NgPackagr Builder', () => {
     );
 
     architect = new Architect(architectHost, registry);
+
+    // Set AOT compilation to use VE if needed.
+    if (veEnabled) {
+      host.replaceInFile('tsconfig.json', `"enableIvy": true,`, `"enableIvy": false,`);
+    }
   });
 
   afterEach(() => host.restore().toPromise());

tests/angular_devkit/build_ng_packagr/ng-packaged-ve/.gitignore renamed to packages/angular_devkit/build_ng_packagr/test/ng-packaged/.gitignore

@@ -0,0 +1,24 @@
+{
+  "$schema": "../../../../packages/angular_devkit/core/src/workspace/workspace-schema.json",
+  "version": 1,
+  "projects": {
+    "lib": {
+      "root": "projects/lib",
+      "projectType": "library",
+      "targets": {
+        "build": {
+          "builder": "@angular-devkit/build-ng-packagr:build",
+          "options": {
+            "project": "projects/lib/ng-package.json",
+            "tsConfig": "projects/lib/tsconfig.lib.json"
+          },
+          "configurations": {
+            "production": {
+              "tsConfig": "projects/lib/tsconfig.lib.prod.json"
+            }
+          }
+        }
+      }
+    }
+  }
+}

packages/angular_devkit/build_ng_packagr/test/ng-packaged/angular.json

@@ -18,6 +18,7 @@
     ]
   },
   "angularCompilerOptions": {
+    "enableIvy": true,
     "disableTypeScriptVersionCheck": true
   }
 }