Skip to content

Commit 2cfe1a4

Browse files
committed
fix(@schematics/schematics): Make sure promise returning methods are async
Method returning Promise should be async Rationale: https://palantir.github.io/tslint/rules/promise-function-async/
1 parent 0cb6dff commit 2cfe1a4

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { browser, by, element } from 'protractor';
22

33
export class AppPage {
4-
navigateTo(): Promise<unknown> {
4+
async navigateTo(): Promise<unknown> {
55
return browser.get(browser.baseUrl) as Promise<unknown>;
66
}
77

8-
getTitleText(): Promise<string> {
8+
async getTitleText(): Promise<string> {
99
return element(by.css('app-root .content span')).getText() as Promise<string>;
1010
}
1111
}

packages/angular_devkit/build_angular/test/hello-world-app/e2e/app.po.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
import { browser, by, element } from 'protractor';
99

1010
export class AppPage {
11-
navigateTo(): Promise<unknown> {
11+
async navigateTo(): Promise<unknown> {
1212
return browser.get(browser.baseUrl) as Promise<unknown>;
1313
}
1414

15-
getTitleText(): Promise<string> {
15+
async getTitleText(): Promise<string> {
1616
return element(by.css('app-root h1')).getText() as Promise<string>;
1717
}
1818
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { browser, by, element } from 'protractor';
22

33
export class AppPage {
4-
navigateTo(): Promise<unknown> {
4+
async navigateTo(): Promise<unknown> {
55
return browser.get(browser.baseUrl) as Promise<unknown>;
66
}
77

8-
getTitleText(): Promise<string> {
8+
async getTitleText(): Promise<string> {
99
return element(by.css('<%= rootSelector %> .content span')).getText() as Promise<string>;
1010
}
1111
}

0 commit comments

Comments
 (0)