Skip to content

Commit 2e4cae1

Browse files
clydinKeen Yee Liau
authored andcommitted
test: remove additional usages of experimental workspaces
1 parent f169e09 commit 2e4cae1

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

packages/angular_devkit/build_angular/test/tslint/works_spec_large.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@ import { Architect, Target } from '@angular-devkit/architect';
99
import { WorkspaceNodeModulesArchitectHost } from '@angular-devkit/architect/node';
1010
import { TestingArchitectHost } from '@angular-devkit/architect/testing';
1111
import {
12-
experimental,
1312
logging,
1413
normalize,
1514
schema,
15+
workspaces,
1616
} from '@angular-devkit/core';
17-
import { NodeJsSyncHost } from '@angular-devkit/core/node';
18-
import * as fs from 'fs';
17+
import { NodeJsAsyncHost } from '@angular-devkit/core/node';
1918
import * as path from 'path';
2019

2120
const devkitRoot = (global as any)._DevKitRoot; // tslint:disable-line:no-any
@@ -30,16 +29,13 @@ describe('Tslint Target', () => {
3029
let architect: Architect;
3130

3231
beforeEach(async () => {
33-
const vfHost = new NodeJsSyncHost();
34-
const configPath = path.join(workspaceRoot, 'angular.json');
35-
const configContent = fs.readFileSync(configPath, 'utf-8');
36-
const workspaceJson = JSON.parse(configContent);
37-
3832
const registry = new schema.CoreSchemaRegistry();
3933
registry.addPostTransform(schema.transforms.addUndefinedDefaults);
4034

41-
const workspace = new experimental.workspace.Workspace(normalize(workspaceRoot), vfHost);
42-
await workspace.loadWorkspaceFromJson(workspaceJson).toPromise();
35+
const { workspace } = await workspaces.readWorkspace(
36+
normalize(workspaceRoot),
37+
workspaces.createWorkspaceHost(new NodeJsAsyncHost()),
38+
);
4339

4440
testArchitectHost = new TestingArchitectHost(
4541
workspaceRoot,

packages/angular_devkit/build_angular/test/utils.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ import { WorkspaceNodeModulesArchitectHost } from '@angular-devkit/architect/nod
1010
import { TestProjectHost, TestingArchitectHost } from '@angular-devkit/architect/testing';
1111
import {
1212
Path,
13-
experimental,
1413
getSystemPath,
1514
join,
1615
json,
1716
normalize,
1817
schema,
1918
virtualFs,
19+
workspaces,
2020
} from '@angular-devkit/core';
2121
import { BrowserBuilderOutput } from '../src/browser';
2222

@@ -42,7 +42,10 @@ export async function createArchitect(workspaceRoot: Path) {
4242
registry.addPostTransform(schema.transforms.addUndefinedDefaults);
4343
const workspaceSysPath = getSystemPath(workspaceRoot);
4444

45-
const workspace = await experimental.workspace.Workspace.fromPath(host, host.root(), registry);
45+
const { workspace } = await workspaces.readWorkspace(
46+
workspaceSysPath,
47+
workspaces.createWorkspaceHost(host),
48+
);
4649
const architectHost = new TestingArchitectHost(
4750
workspaceSysPath,
4851
workspaceSysPath,

packages/angular_devkit/build_ng_packagr/src/build/index_spec_large.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import { Architect } from '@angular-devkit/architect';
99
import { WorkspaceNodeModulesArchitectHost } from '@angular-devkit/architect/node';
1010
import { TestProjectHost, TestingArchitectHost } from '@angular-devkit/architect/testing';
1111
import {
12-
experimental,
1312
getSystemPath,
1413
join,
1514
normalize,
1615
schema,
1716
virtualFs,
17+
workspaces,
1818
} from '@angular-devkit/core'; // tslint:disable-line:no-implicit-dependencies
1919
import { map, take, tap } from 'rxjs/operators';
2020

@@ -37,7 +37,10 @@ describe('NgPackagr Builder', () => {
3737
registry.addPostTransform(schema.transforms.addUndefinedDefaults);
3838

3939
const workspaceSysPath = getSystemPath(host.root());
40-
const workspace = await experimental.workspace.Workspace.fromPath(host, host.root(), registry);
40+
const { workspace } = await workspaces.readWorkspace(
41+
workspaceSysPath,
42+
workspaces.createWorkspaceHost(host),
43+
);
4144
const architectHost = new TestingArchitectHost(
4245
workspaceSysPath,
4346
workspaceSysPath,

0 commit comments

Comments
 (0)