test(@angular-devkit/build-angular): test in debug mode for increased perf

Author: filipesilva

integration/build_angular/BUILD.bazel

@@ -11,6 +11,8 @@ filegroup(
     ),
 )
 
+YARN_CACHE_FLAG = "--cache-folder ./.yarn_local_cache"
+
 INTEGRATION_TESTS = [
     "app-shell",
     "browser-1",
@@ -45,22 +47,29 @@ INTEGRATION_TESTS = [
             "//packages/ngtools/webpack:npm_package_archive": "@ngtools/webpack",
         },
         commands = [
+            "patch-package-json",
             # Workaround https://github.com/yarnpkg/yarn/issues/2165
             # Yarn will cache file://dist URIs and not update
-            "rm -rf ./.yarn_local_cache",
-            "mkdir .yarn_local_cache",
-            "patch-package-json",
-            "$(rootpath @nodejs//:yarn_bin) install --cache-folder ./.yarn_local_cache",
+            "$(rootpath @nodejs//:yarn_bin) cache clean @angular-devkit/architect " + YARN_CACHE_FLAG,
+            "$(rootpath @nodejs//:yarn_bin) cache clean @angular-devkit/build-angular " + YARN_CACHE_FLAG,
+            "$(rootpath @nodejs//:yarn_bin) cache clean @angular-devkit/build-optimizer " + YARN_CACHE_FLAG,
+            "$(rootpath @nodejs//:yarn_bin) cache clean @angular-devkit/build-webpack " + YARN_CACHE_FLAG,
+            "$(rootpath @nodejs//:yarn_bin) cache clean @angular-devkit/core " + YARN_CACHE_FLAG,
+            "$(rootpath @nodejs//:yarn_bin) cache clean @ngtools/webpack " + YARN_CACHE_FLAG,
+            "$(rootpath @nodejs//:yarn_bin) install " + YARN_CACHE_FLAG,
             "$(rootpath @nodejs//:yarn_bin) test-" + test_name,
-            "rm -rf ./.yarn_local_cache",
         ],
         data = [
             "@nodejs//:yarn_bin",
             "@nodejs//:yarn_files",
         ],
         test_files = ":build_angular_sources",
         size = "large",
-        tags = ["exclusive"]
+        tags = ["exclusive"],
+        # This test contains a lot of node modules that can take up to 100s to install.
+        # Instead of completely isolating the test and the cache, this one is run in-place so it 
+        # reuses the local node_modules and cache for all tests in this BUILD file.
+        debug = True
     )
     for test_name in INTEGRATION_TESTS
 ]

integration/build_angular/yarn.lock

@@ -2,25 +2,25 @@
 # yarn lockfile v1
 
 
-"@angular-devkit/[email protected]", "@angular-devkit/architect@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz":
+"@angular-devkit/[email protected]", "@angular-devkit/architect@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz":
   version "0.0.0"
-  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz#d3c85d7181b11ba4cd2357f70869d263e21e7296"
+  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz#d3c85d7181b11ba4cd2357f70869d263e21e7296"
   dependencies:
     "@angular-devkit/core" "0.0.0"
     rxjs "6.5.4"
 
-"@angular-devkit/architect@file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz":
+"@angular-devkit/architect@file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz":
   version "0.0.0"
   uid d3c85d7181b11ba4cd2357f70869d263e21e7296
-  resolved "file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz#d3c85d7181b11ba4cd2357f70869d263e21e7296"
+  resolved "file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/architect/npm_package_archive.tar.gz#d3c85d7181b11ba4cd2357f70869d263e21e7296"
   dependencies:
     "@angular-devkit/core" "0.0.0"
     rxjs "6.5.4"
 
-"@angular-devkit/build-angular@file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz":
+"@angular-devkit/build-angular@file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz":
   version "0.0.0"
-  uid "840f4668452bb3fbcd0193b7282f727855ad9142"
-  resolved "file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz#840f4668452bb3fbcd0193b7282f727855ad9142"
+  uid dd8aca592c550efd5076bca3c8fdf4822b6a8f0b
+  resolved "file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz#dd8aca592c550efd5076bca3c8fdf4822b6a8f0b"
   dependencies:
     "@angular-devkit/architect" "0.0.0"
     "@angular-devkit/build-optimizer" "0.0.0"
@@ -83,9 +83,9 @@
     webpack-subresource-integrity "1.4.0"
     worker-plugin "3.2.0"
 
-"@angular-devkit/build-angular@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz":
+"@angular-devkit/build-angular@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz":
   version "0.0.0"
-  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz#840f4668452bb3fbcd0193b7282f727855ad9142"
+  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/npm_package_archive.tar.gz#dd8aca592c550efd5076bca3c8fdf4822b6a8f0b"
   dependencies:
     "@angular-devkit/architect" "0.0.0"
     "@angular-devkit/build-optimizer" "0.0.0"
@@ -148,38 +148,38 @@
     webpack-subresource-integrity "1.4.0"
     worker-plugin "3.2.0"
 
-"@angular-devkit/[email protected]", "@angular-devkit/build-optimizer@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_optimizer/npm_package_archive.tar.gz":
+"@angular-devkit/[email protected]", "@angular-devkit/build-optimizer@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_optimizer/npm_package_archive.tar.gz":
   version "0.0.0"
-  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_optimizer/npm_package_archive.tar.gz#0e3efaa3bee0d3f6177896c7fc0bf0a7eb9aac57"
+  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_optimizer/npm_package_archive.tar.gz#0e3efaa3bee0d3f6177896c7fc0bf0a7eb9aac57"
   dependencies:
     loader-utils "1.4.0"
     source-map "0.7.3"
     tslib "1.11.1"
     typescript "3.8.3"
     webpack-sources "1.4.3"
 
-"@angular-devkit/[email protected]", "@angular-devkit/build-webpack@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_webpack/npm_package_archive.tar.gz":
+"@angular-devkit/[email protected]", "@angular-devkit/build-webpack@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_webpack/npm_package_archive.tar.gz":
   version "0.0.0"
-  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/build_webpack/npm_package_archive.tar.gz#0ff97f366df3f7e9516847c37900ecd6dab5c453"
+  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/build_webpack/npm_package_archive.tar.gz#647e743a8aceacd4aeeb78dd134850cfbeff88ac"
   dependencies:
     "@angular-devkit/architect" "0.0.0"
     "@angular-devkit/core" "0.0.0"
     rxjs "6.5.4"
 
-"@angular-devkit/[email protected]", "@angular-devkit/core@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz":
+"@angular-devkit/[email protected]", "@angular-devkit/core@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz":
   version "0.0.0"
-  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz#c005055236edb49d53b9cbe8555d3d6729ca8a17"
+  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz#c005055236edb49d53b9cbe8555d3d6729ca8a17"
   dependencies:
     ajv "6.12.0"
     fast-json-stable-stringify "2.1.0"
     magic-string "0.25.6"
     rxjs "6.5.4"
     source-map "0.7.3"
 
-"@angular-devkit/core@file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz":
+"@angular-devkit/core@file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz":
   version "0.0.0"
   uid c005055236edb49d53b9cbe8555d3d6729ca8a17
-  resolved "file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz#c005055236edb49d53b9cbe8555d3d6729ca8a17"
+  resolved "file:../../../../.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/angular_devkit/core/npm_package_archive.tar.gz#c005055236edb49d53b9cbe8555d3d6729ca8a17"
   dependencies:
     ajv "6.12.0"
     fast-json-stable-stringify "2.1.0"
@@ -1049,9 +1049,9 @@
   resolved "https://registry.yarnpkg.com/@istanbuljs/schema/-/schema-0.1.2.tgz#26520bf09abe4a5644cd5414e37125a8954241dd"
   integrity sha512-tsAQNx32a8CoFhjhijUIhI4kccIAgmGhy8LZMZgGfmXcpMbPRUqn5LWmgRttILi6yeGmBJd2xsPkFMs0PzgPCw==
 
-"@ngtools/[email protected]", "@ngtools/webpack@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/ngtools/webpack/npm_package_archive.tar.gz":
+"@ngtools/[email protected]", "@ngtools/webpack@file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/ngtools/webpack/npm_package_archive.tar.gz":
   version "0.0.0"
-  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/dev-server.debug.sh.runfiles/angular_cli/packages/ngtools/webpack/npm_package_archive.tar.gz#af035a4ae6d4d0080b4b3a8186bff9428bbe869b"
+  resolved "file:/home/filipesilva/.cache/bazel/_bazel_filipesilva/e327cb0949caea626cba080635966a9f/execroot/angular_cli/bazel-out/k8-fastbuild/bin/integration/build_angular/server.sh.runfiles/angular_cli/packages/ngtools/webpack/npm_package_archive.tar.gz#af035a4ae6d4d0080b4b3a8186bff9428bbe869b"
   dependencies:
     "@angular-devkit/core" "0.0.0"
     enhanced-resolve "4.1.1"

tools/npm_integration_test/npm_integration_test.bzl

@@ -145,6 +145,7 @@ def npm_integration_test(name, **kwargs):
     npm_packages = kwargs.pop("npm_packages", {})
     test_files = kwargs.pop("test_files", [])
     data = kwargs.pop("data", [])
+    debug = kwargs.pop("debug", False)
 
     _npm_integration_test_config(
         name = name + ".config",
@@ -157,6 +158,7 @@ def npm_integration_test(name, **kwargs):
         visibility = ["//visibility:private"],
         tags = ["manual"],
         testonly = True,
+        debug = debug,
     )
 
     # Config for debug target below