Skip to content

Commit 42f827b

Browse files
nlm-prohansl
authored andcommitted
build: add v8-profiler typings
After some refactoring on the angular/cli init, v8-profiler typing is required in order to fix a no-any lint error.
1 parent 774f6d6 commit 42f827b

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
"@types/request": "^2.47.1",
8888
"@types/semver": "^5.5.0",
8989
"@types/source-map": "0.5.2",
90+
"@types/v8-profiler": "^0.0.5",
9091
"@types/webpack": "^4.4.11",
9192
"@types/webpack-dev-server": "^3.1.0",
9293
"@types/webpack-sources": "^0.1.5",

packages/angular/cli/lib/init.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ import { SemVer } from 'semver';
1616
import { Duplex } from 'stream';
1717
import { isWarningEnabled } from '../utilities/config';
1818

19+
import { Profiler } from 'v8-profiler';
20+
1921
const packageJson = require('../package.json');
2022

2123
function _fromPackageJson(cwd?: string) {
@@ -43,7 +45,7 @@ function _fromPackageJson(cwd?: string) {
4345

4446
// Check if we need to profile this CLI run.
4547
if (process.env['NG_CLI_PROFILING']) {
46-
let profiler: any = null;
48+
let profiler: Profiler;
4749
try {
4850
profiler = require('v8-profiler-node8'); // tslint:disable-line:no-implicit-dependencies
4951
} catch (err) {

yarn.lock

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -463,6 +463,12 @@
463463
version "1.0.1"
464464
resolved "https://codeload.github.com/quicktype/types-urijs/tar.gz/a23603a04e31e883a92244bff8515e3d841a8b98"
465465

466+
"@types/v8-profiler@^0.0.5":
467+
version "0.0.5"
468+
resolved "https://registry.yarnpkg.com/@types/v8-profiler/-/v8-profiler-0.0.5.tgz#2b9f0b7ba3294f5b177b66790607772910a195f9"
469+
dependencies:
470+
"@types/node" "*"
471+
466472
"@types/webpack-dev-server@^3.1.0":
467473
version "3.1.0"
468474
resolved "https://registry.yarnpkg.com/@types/webpack-dev-server/-/webpack-dev-server-3.1.0.tgz#1fae06ad346d2dd09bc5e34745723946458eed58"

0 commit comments

Comments
 (0)