Skip to content

Commit 431df79

Browse files
filipesilvavikerman
authored andcommitted
fix(@angular-devkit/build-angular): dont serve files on cwd (#12547)
1 parent 916a616 commit 431df79

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

packages/angular_devkit/build_angular/src/dev-server/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ export class DevServerBuilder implements Builder<DevServerBuilderOptions> {
227227
disableHostCheck: options.disableHostCheck,
228228
publicPath: servePath,
229229
hot: options.hmr,
230+
contentBase: false,
230231
};
231232

232233
if (options.ssl) {

packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,16 @@ describe('Dev Server Builder', () => {
3434
take(1),
3535
).toPromise().then(done, done.fail);
3636
}, 30000);
37+
38+
it(`doesn't serve files on the cwd directly`, async () => {
39+
const res = await runTargetSpec(host, devServerTargetSpec).pipe(
40+
tap((buildEvent) => expect(buildEvent.success).toBe(true)),
41+
// When webpack-dev-server doesn't have `contentBase: false`, this will serve the repo README.
42+
concatMap(() => from(request('http://localhost:4200/README.md'))),
43+
take(1),
44+
).toPromise();
45+
46+
expect(res).not.toContain('This file is automatically generated during release.');
47+
expect(res).toContain('<title>HelloWorldApp</title>');
48+
});
3749
});

0 commit comments

Comments
 (0)