Skip to content

Commit 6ceafa5

Browse files
josephperrottmgechev
authored andcommitted
build: default to wombat proxy for publishing
If no --registry argument is provided when calling to publish use the Wombat proxy. Additionally, updates the release process documentation to instruct usage of the Wombat proxy.
1 parent 8c86914 commit 6ceafa5

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

docs/process/release.md

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,21 +105,18 @@ git push upstream && git push upstream --tags
105105

106106
**This can ONLY be done by a Google employee.**
107107

108-
Log in to [NPM](https://npmjs.com/) to the `angular` account in order to
109-
publish. This account is protected by two factor authentication (2FA).
108+
Log in to the Wombat publishing service using your own github and google.com
109+
account to publish. This enforces the loging is done using 2Factor auth.
110110

111-
Run `npm login`:
111+
Run `npm login --registry https://wombat-dressing-room.appspot.com`:
112112

113-
1. For username, use `angular`.
114-
1. For password, use the value stored [here](http://go/ng-npm-pass).
115-
1. For email, use `[email protected]`.
116-
1. For two-factor code, you'll need to set up the account.
117-
* Use an authenticator app such as [Google Authenticator](https://play.google.com/store/apps/details?id=com.google.android.apps.authenticator2).
118-
* Add a new account and enter the text key from [here](http://go/ng-npm-2fa).
119-
* The app will start showing two-factor codes, enter one into the
120-
`npm login` prompt.
113+
1. In the new browser tab, the registry app will ask you to connect with GitHub to create a token
114+
1. After connecting with github, you will be redirected to create a token
115+
1. Upon redirect, an auth token is added to your ~/.npmrc for the proxy
121116

122-
Once successfully logged in, it is time to publish.
117+
After closing the tab, you have successfully logged in, it is time to publish.
118+
119+
**NOTE: After publishing, remove the token added to your `~/.npmrc` file to logout.**
123120

124121
### Publishing
125122

scripts/publish.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ export default async function (args: PublishArgs, logger: logging.Logger) {
116116
if (args.tag) {
117117
publishArgs.push('--tag', args.tag);
118118
}
119-
if (args.registry) {
120-
publishArgs.push('--registry', args.registry);
121-
}
119+
120+
// If no registry is provided, the wombat proxy should be used.
121+
publishArgs.push('--registry', args.registry || 'https://wombat-dressing-room.appspot.com');
122122

123123
return _exec('npm', publishArgs, {
124124
cwd: pkg.dist,

0 commit comments

Comments
 (0)