File tree Expand file tree Collapse file tree 3 files changed +23
-9
lines changed Expand file tree Collapse file tree 3 files changed +23
-9
lines changed Original file line number Diff line number Diff line change @@ -110,14 +110,21 @@ Before you submit your Pull Request (PR) consider the following guidelines:
110
110
* If we suggest changes then:
111
111
* Make the required updates.
112
112
* Re-run the Angular DevKit test suites to ensure tests are still passing.
113
- * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
113
+ * Once your PR is approved and you are done with any follow up changes:
114
+ * Rebase to the current master to pre-emptively address any merge conflicts.
114
115
115
116
` ` ` shell
116
117
git rebase master -i
117
118
git push -f
118
119
` ` `
120
+ * Add the ` PR action: merge` label and the correct
121
+ [target label](https://github.com/angular/angular/blob/master/docs/TRIAGE_AND_LABELS.md#pr-target)
122
+ (if PR author has the project collaborator status, or else the last reviewer
123
+ should do this).
124
+ * The current caretaker will merge the PR to the target branch(es) within 1-2
125
+ business days.
119
126
120
- That' s it! Thank you for your contribution!
127
+ That' s it! 🎉 Thank you for your contribution!
121
128
122
129
#### After your pull request is merged
123
130
@@ -301,12 +308,12 @@ yarn bazel run //etc/api:angular_devkit_core_api.accept
301
308
**Note**: In some cases we use aliased symbols to create namespaces.
302
309
303
310
Example:
304
- ```javascript
311
+ ```javascript
305
312
import * as foo from ' ./foo' ;
306
313
307
314
export { foo };
308
315
```
309
- There are currently not supported by the API guardian.
316
+ There are currently not supported by the API guardian.
310
317
To overcome this limitation we created `_golden-api.ts` in certain packages.
311
318
312
319
When adding a new API, it might be the case that you need to add it to `_golden-api.ts`.
Original file line number Diff line number Diff line change 18
18
## Merging PRs
19
19
20
20
The list of PRs which are currently ready to merge (approved with passing status checks) can
21
- be found with [ this search] ( https://github.com/angular/angular-cli/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+status%3Asuccess ) .
21
+ be found with [ this search] ( https://github.com/angular/angular-cli/pulls?q=is%3Apr+is%3Aopen+label%3A%22PR+action%3A+merge%22 ) .
22
22
This list should be checked daily and any ready PRs should be merged. For each
23
23
PR, check the ` PR target ` label to understand where it should be merged to. If
24
24
` master ` is targetted, then click "Rebase and Merge". If the PR also targets a
Original file line number Diff line number Diff line change @@ -110,14 +110,21 @@ Before you submit your Pull Request (PR) consider the following guidelines:
110
110
* If we suggest changes then:
111
111
* Make the required updates.
112
112
* Re-run the Angular DevKit test suites to ensure tests are still passing.
113
- * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
113
+ * Once your PR is approved and you are done with any follow up changes:
114
+ * Rebase to the current master to pre-emptively address any merge conflicts.
114
115
115
116
```shell
116
117
git rebase master -i
117
118
git push -f
118
119
```
120
+ * Add the `PR action: merge` label and the correct
121
+ [target label](https://github.com/angular/angular/blob/master/docs/TRIAGE_AND_LABELS.md#pr-target)
122
+ (if PR author has the project collaborator status, or else the last reviewer
123
+ should do this).
124
+ * The current caretaker will merge the PR to the target branch(es) within 1-2
125
+ business days.
119
126
120
- That's it! Thank you for your contribution!
127
+ That's it! 🎉 Thank you for your contribution!
121
128
122
129
#### After your pull request is merged
123
130
@@ -290,12 +297,12 @@ yarn bazel run //etc/api:angular_devkit_core_api.accept
290
297
**Note**: In some cases we use aliased symbols to create namespaces.
291
298
292
299
Example:
293
- ```javascript
300
+ ```javascript
294
301
import * as foo from './foo';
295
302
296
303
export { foo };
297
304
```
298
- There are currently not supported by the API guardian.
305
+ There are currently not supported by the API guardian.
299
306
To overcome this limitation we created `_golden-api.ts` in certain packages.
300
307
301
308
When adding a new API, it might be the case that you need to add it to `_golden-api.ts`.
You can’t perform that action at this time.
0 commit comments