Skip to content

Commit 91d7a6e

Browse files
filipesilvavikerman
authored andcommitted
test: move dynamic import exclusion to test
1 parent 2383641 commit 91d7a6e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

tests/legacy-cli/e2e/tests/build/dynamic-import.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
11
import * as fs from 'fs';
2+
import { getGlobalVariable } from '../../utils/env';
23
import { writeFile } from '../../utils/fs';
34
import { ng } from '../../utils/process';
45
import { updateJsonFile } from '../../utils/project';
56

67

78
export default async function() {
9+
if (!(getGlobalVariable('argv')['ve'])) {
10+
// Only applicable to VE. Does not apply to Ivy.
11+
return;
12+
}
13+
814
// Add a lazy module
915
await ng('generate', 'module', 'lazy');
1016
await updateJsonFile('angular.json', workspaceJson => {

tests/legacy-cli/e2e_runner.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ if (!argv.ve) {
102102
// Ivy doesn't support i18n externally at the moment.
103103
.filter(name => !name.includes('tests/i18n/'))
104104
.filter(name => !name.endsWith('tests/build/aot/aot-i18n.ts'))
105-
// The additional lazy modules array does not work with Ivy because it's not needed.
106-
.filter(name => !name.endsWith('tests/build/dynamic-import.ts'))
107105
// We don't have a platform-server usage story yet for Ivy.
108106
// It's contingent on lazy loading and factory shim considerations that are still being
109107
// discussed.

0 commit comments

Comments
 (0)