Skip to content

Commit 97576ec

Browse files
committed
fix(@angular/cli): do not show stack on argument parse error
1 parent f7f5b28 commit 97576ec

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

packages/angular/cli/models/command-runner.ts

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,20 @@ export async function runCommand(
182182
return 1;
183183
}
184184

185-
const parsedOptions = parser.parseArguments(args, description.options);
186-
Command.setCommandMap(commandMap);
187-
const command = new description.impl({ workspace }, description, logger);
188-
189-
return await command.validateAndRun(parsedOptions);
185+
try {
186+
const parsedOptions = parser.parseArguments(args, description.options);
187+
Command.setCommandMap(commandMap);
188+
const command = new description.impl({ workspace }, description, logger);
189+
190+
return await command.validateAndRun(parsedOptions);
191+
} catch (e) {
192+
if (e instanceof parser.ParseArgumentException) {
193+
logger.fatal('Cannot parse arguments. See below for the reasons.');
194+
logger.fatal(' ' + e.comments.join('\n '));
195+
196+
return 1;
197+
} else {
198+
throw e;
199+
}
200+
}
190201
}

packages/angular/cli/models/parser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { Arguments, Option, OptionType, Value } from './interface';
1212

1313
export class ParseArgumentException extends BaseException {
1414
constructor(
15-
comments: string[],
15+
public readonly comments: string[],
1616
public readonly parsed: Arguments,
1717
public readonly ignored: string[],
1818
) {

0 commit comments

Comments
 (0)