Skip to content

Commit b716081

Browse files
alan-agius4clydin
authored andcommitted
fix(@angular-devkit/build-angular): close compiler on Karma exit
The webpack compiler was never closed which caused Webpack's shutdown hook https://github.com/angular/angular-cli/blob/c71832f3a9942aeb2c3dbd62f6edb4f0b8366465/packages/angular_devkit/build_angular/src/webpack/configs/styles.ts#L113-L114 to never be called and in turn caused the Sass workers never to be termined.
1 parent f99c08c commit b716081

File tree

1 file changed

+1
-1
lines changed
  • packages/angular_devkit/build_angular/src/webpack/plugins/karma

1 file changed

+1
-1
lines changed

packages/angular_devkit/build_angular/src/webpack/plugins/karma/karma.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ const init: any = (config: any, emitter: any) => {
149149
webpackMiddleware = webpackDevMiddleware(compiler, webpackMiddlewareConfig);
150150
emitter.on('exit', (done: any) => {
151151
webpackMiddleware.close();
152-
done();
152+
compiler.close(() => done());
153153
});
154154

155155
function unblock() {

0 commit comments

Comments
 (0)