ci: remove appveyor and buildkite

Author: filipesilva

.appveyor.yml

@@ -41,13 +41,13 @@ merge:
 
     # list of PR statuses that need to be successful
     requiredStatuses:
-      - "continuous-integration/appveyor/pr"
       - "ci/circleci: build"
       - "ci/circleci: build-bazel"
       - "ci/circleci: install"
       - "ci/circleci: lint"
       - "ci/circleci: validate"
       - "ci/circleci: test"
+      - "ci/circleci: test-win"
       - "ci/circleci: test-large"
 
   # the comment that will be added when the merge label is added despite failing checks, leave empty or set to false to disable

.buildkite/pipeline.yml

@@ -27,7 +27,7 @@ describe('Dev Server Builder', () => {
     await Promise.all(runs.map(r => r.stop()));
   });
 
-  it('works', async () => {
+  fit('works', async () => {
     const run = await architect.scheduleTarget(target);
     runs.push(run);
     const output = await run.result as DevServerBuilderOutput;

.github/angular-robot.yml

@@ -8,11 +8,6 @@
 import { Architect } from '@angular-devkit/architect';
 import { createArchitect, host, karmaTargetSpec } from '../utils';
 
-// TODO: replace this with an "it()" macro that's reusable globally.
-let linuxOnlyIt: typeof it = it;
-if (process.platform.startsWith('win')) {
-  linuxOnlyIt = xit;
-}
 
 // tslint:disable-next-line:no-big-function
 describe('Karma Builder', () => {
@@ -33,9 +28,7 @@ describe('Karma Builder', () => {
     await run.stop();
   });
 
-  // This test seems to succeed on appveyor but not terminate Karma, leaving the port used
-  // and killing Chrome after 60s. This causes other tests that use Chrome to fail.
-  linuxOnlyIt('fails with broken compilation', async () => {
+  it('fails with broken compilation', async () => {
     host.writeMultipleFiles({
       'src/app/app.component.spec.ts': '<p> definitely not typescript </p>',
     });

appveyor-e2e.bat

@@ -14,14 +14,6 @@ import { addUndefinedDefaults } from './transforms';
 
 describe('CoreSchemaRegistry', () => {
   it('works asynchronously', done => {
-    if (process.platform.startsWith('win')) {
-      // This test consistently fails on Windows BuildKite, but doesn't fail on local Windows
-      // or in Appveyor. Many tests test the async behaviour of the registry, but this is the only
-      // one that also fetches an async ref. Perhaps that is why.
-      done();
-
-      return;
-    }
     const registry = new CoreSchemaRegistry();
     registry.addPostTransform(addUndefinedDefaults);
     const data: any = {};  // tslint:disable-line:no-any

packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts

@@ -158,18 +158,6 @@ if (process.argv.indexOf('--spec-reporter') != -1) {
 // Manually set exit code (needed with custom reporters)
 runner.onComplete((success: boolean) => {
   process.exitCode = success ? 0 : 1;
-  if (process.platform.startsWith('win')) {
-    // TODO(filipesilva): finish figuring out why this happens.
-    // We should not need to force exit here, but when:
-    // - on windows
-    // - running webpack-dev-server
-    // - with ngtools/webpack on the compilation
-    // Something seems to hang and the process never exists.
-    // This does not happen on linux, nor with webpack on watch mode.
-    // Until this is figured out, we need to exit the process manually after tests finish
-    // otherwise appveyor will hang until it timeouts.
-    process.exit();
-  }
 });
 
 

packages/angular_devkit/build_angular/test/karma/works_spec_large.ts

@@ -44,7 +44,6 @@ Error.stackTraceLimit = Infinity;
  */
 const argv = minimist(process.argv.slice(2), {
   'boolean': [
-    'appveyor',
     'debug',
     'ng-snapshots',
     'noglobal',