Skip to content

Commit c73a378

Browse files
gregmagolanfilipesilva
authored andcommitted
build: run tests depending on webdriver-manager locally
1 parent 903839a commit c73a378

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

.bazelrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,11 @@ build:remote --bes_results_url="https://source.cloud.google.com/results/invocati
125125
# Set remote caching settings
126126
build:remote --remote_accept_cached=true
127127

128+
# Force remote executions to consider the entire run as linux.
129+
# This is required for OSX cross-platform RBE.
130+
build:remote --cpu=k8
131+
build:remote --host_cpu=k8
132+
128133
###############################
129134
# NodeJS rules settings
130135
# These settings are required for rules_nodejs

packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,8 @@ LARGE_SPECS = {
261261
"@npm//puppeteer",
262262
"@npm//ts-node",
263263
],
264+
# NB: must be run locally because webdriver manager uses an absolute path to chromedriver
265+
"tags": ["local"],
264266
},
265267
"dev-server": {
266268
"extra_deps": [
@@ -288,6 +290,10 @@ LARGE_SPECS = {
288290
"@npm//puppeteer",
289291
"@npm//ts-node",
290292
],
293+
# NB: must be run locally because webdriver manager uses an absolute path to chromedriver
294+
"tags": ["local"],
295+
# NB: multiple shards will compete for port 4200 so limiting to 1
296+
"shards": 1,
291297
},
292298
"tslint": {
293299
"extra_deps": [
@@ -363,7 +369,7 @@ LARGE_SPECS = {
363369
# These tests are resource intensive and should not be over-parallized as they will
364370
# compete for the resources of other parallel tests slowing everything down.
365371
# Ask Bazel to allocate multiple CPUs for these tests with "cpu:n" tag.
366-
tags = ["cpu:2"],
372+
tags = ["cpu:2"] + LARGE_SPECS[spec].get("tags", []),
367373
templated_args = ["--nobazel_patch_module_resolver"],
368374
deps = [":build_angular_" + spec + "_test_lib"],
369375
)

0 commit comments

Comments
 (0)